You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Sahoo (JIRA)" <ji...@apache.org> on 2010/02/12 09:15:32 UTC
[jira] Created: (FELIX-2069) FileInstall creates ./load by default
FileInstall creates ./load by default
-------------------------------------
Key: FELIX-2069
URL: https://issues.apache.org/jira/browse/FELIX-2069
Project: Felix
Issue Type: Bug
Components: File Install
Reporter: Sahoo
If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2069) FileInstall creates ./load by
default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855294#action_12855294 ]
Sahoo commented on FELIX-2069:
------------------------------
Anyone else has any particular preference here? I would like a conclusion soon so that we can decide whether to include this in next release.
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-2069) FileInstall creates ./load by default
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall reassigned FELIX-2069:
--------------------------------------
Assignee: Richard S. Hall
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Assignee: Richard S. Hall
> Attachments: FELIX-2069.patch.txt, FELIX-2069.patch2.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2069) FileInstall creates ./load by
default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855297#action_12855297 ]
Sahoo commented on FELIX-2069:
------------------------------
For me the real problem is creation of ./load. I noticed my file system have many ./load directories and they must have been created because I would have started fileinstall bundle without configuring it properly. I am fine with introducing the flag as you mentioned. IIUC, when the flag is set to false (when not set, it defaults to false), it will take care of not creating the dir as well.
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2069) FileInstall creates ./load by default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sahoo updated FELIX-2069:
-------------------------
Attachment: (was: FELIX-2069.patch2.txt)
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2069) FileInstall creates ./load by
default
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855300#action_12855300 ]
Marcel Offermans commented on FELIX-2069:
-----------------------------------------
So let's not create any folder (configured or default).
As far as I'm concerned we can then stick with the default being "load". I really dislike creating files or folders that are useful for users in /tmp as that is a "scratch" folder for non-human use.
The user should be warned if the (default or configured) folder does not exist (in which case FileInstall should keep monitoring the filesystem because the user might still create it manually afterwards).
These changes will break backward compatibility, so we would have to bump the version to 3.0.0 but that's no problem.
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2069) FileInstall creates ./load by default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sahoo updated FELIX-2069:
-------------------------
Attachment: FELIX-2069.patch.txt
Simple patch to make fileinstall wait for configuration to arrive instead of creating ./load if no directory is specified.
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2069) FileInstall creates ./load by default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sahoo updated FELIX-2069:
-------------------------
Affects Version/s: fileinstall-2.0.8
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2069) FileInstall creates ./load by
default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855301#action_12855301 ]
Sahoo commented on FELIX-2069:
------------------------------
The above suggestion sounds good to me.
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2069) FileInstall creates ./load by
default
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853075#action_12853075 ]
Marcel Offermans commented on FELIX-2069:
-----------------------------------------
If not configured, it's perfectly fine in general for bundles to assume some kind of defaults and use those. To be honest, I don't like creating a "load" directory in some kind of temporary folder in that case. Creating the "./load" folder to me is a very reasonable default and I don't really see a need to change it.
To me, the only thing you could consider is: should FileInstall create a folder at all? In other words, if "./load" is the default, or whatever other folder is defined, and it does not exist, should FileInstall then create it or simply warn the user that the folder is not there. This would be an API breaking change.
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2069) FileInstall creates ./load by
default
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855295#action_12855295 ]
Guillaume Nodet commented on FELIX-2069:
----------------------------------------
AFAIK, the real problem is not creating the load directory, it's about having this directory being watched by default, right ?
I think having a way to not have any watched directory by default is a good thing, however we may have users that use this behavior.
What about introducing a flag to not watch any directory by default ?
org.felix.fileinstall.noDefaultWatchDir = false
or anything similar with a better name ;-)
We can always change the default value for the next major / minor version instead of the next micro ....
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2069) FileInstall creates ./load by default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sahoo updated FELIX-2069:
-------------------------
Attachment: FELIX-2069.patch2.txt
A new patch that does not create watchedDir (default or configured) if it does not exist. Instead, it prints a message and continues until the watchedDir is available.
I would like someone to look at this patch and apply it soon if it looks OK. I want to call for a release of fileinstall with some of the recent fixes that have been made.
Thanks,
Sahoo
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt, FELIX-2069.patch2.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (FELIX-2069) FileInstall creates ./load by default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sahoo updated FELIX-2069:
-------------------------
Attachment: FELIX-2069.patch2.txt
A new patch that does not create watchedDir (default or configured) if it does not exist. Instead, it prints a message and continues until the watchedDir is available.
I would like someone to look at this patch and apply it soon if it looks OK. I want to call for a release of fileinstall with some of the recent fixes that have been made.
Thanks,
Sahoo
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt, FELIX-2069.patch2.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2069) FileInstall creates ./load by
default
Posted by "Sahoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853084#action_12853084 ]
Sahoo commented on FELIX-2069:
------------------------------
I see no point in FileInstall creating ./load. I am not sure how many people rely on this default behavior. May be we can take a poll to decide whether we need to introduce any flag to keep it compatible or not?
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2069) FileInstall creates ./load by default
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall resolved FELIX-2069.
------------------------------------
Fix Version/s: fileinstall-2.0.10
Resolution: Fixed
The patch looked fine to me...I made a few minor changes and committed it.
I assume we no longer need the first submitted patch, so I didn't commit that. Please let me know if this is incorrect. Otherwise, please close the bug if satisfied. Thanks.
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Assignee: Richard S. Hall
> Fix For: fileinstall-2.0.10
>
> Attachments: FELIX-2069.patch.txt, FELIX-2069.patch2.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2069) FileInstall creates ./load by
default
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853479#action_12853479 ]
Richard S. Hall commented on FELIX-2069:
----------------------------------------
+1 for not creating ./load
> FileInstall creates ./load by default
> -------------------------------------
>
> Key: FELIX-2069
> URL: https://issues.apache.org/jira/browse/FELIX-2069
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-2.0.8
> Reporter: Sahoo
> Attachments: FELIX-2069.patch.txt
>
>
> If not configured, file install bundle creates ./load when it starts. Either it should not create any directory and wait for user to configure it or it should create a directory in tmp folder.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.