You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/10 08:10:20 UTC
[GitHub] [airflow] potiuk opened a new pull request #12232: Added missing sendgrid readme
potiuk opened a new pull request #12232:
URL: https://github.com/apache/airflow/pull/12232
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12232: Added missing sendgrid readme
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12232:
URL: https://github.com/apache/airflow/pull/12232#discussion_r520498368
##########
File path: airflow/providers/sendgrid/PROVIDER_CHANGES_1.0.0b2.md
##########
@@ -0,0 +1,12 @@
+
+
+### Release 1.0.0b2
Review comment:
```suggestion
### Release 1.0.0b1
```
In README and filename too please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12232: Added missing sendgrid readme
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12232:
URL: https://github.com/apache/airflow/pull/12232#discussion_r520425117
##########
File path: airflow/providers/sendgrid/PROVIDER_CHANGES_0.0.1.md
##########
@@ -0,0 +1,12 @@
+
+
+### Release 1.0.0b2
Review comment:
This file and the version number don't match -- does that matter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #12232: Added missing sendgrid readme
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #12232:
URL: https://github.com/apache/airflow/pull/12232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #12232: Added missing sendgrid readme
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #12232:
URL: https://github.com/apache/airflow/pull/12232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12232: Added missing sendgrid readme
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12232:
URL: https://github.com/apache/airflow/pull/12232#issuecomment-724696266
Ah sorry. I had a meeting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12232: Added missing sendgrid readme
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12232:
URL: https://github.com/apache/airflow/pull/12232#discussion_r520427691
##########
File path: airflow/providers/sendgrid/PROVIDER_CHANGES_0.0.1.md
##########
@@ -0,0 +1,12 @@
+
+
+### Release 1.0.0b2
Review comment:
Yep. I have to add proper versioning support (that's one of the remaining tasks)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org