You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2010/03/19 10:05:27 UTC

[jira] Created: (JCR-2577) SISM.checkAddedChildNodes() prevents merging of concurrent changes

SISM.checkAddedChildNodes() prevents merging of concurrent changes
------------------------------------------------------------------

                 Key: JCR-2577
                 URL: https://issues.apache.org/jira/browse/JCR-2577
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: jackrabbit-core
    Affects Versions: 2.0.0
            Reporter: Marcel Reutegger


This is a regression caused by JCR-2456. The check method reports false positives and prevents merges of concurrently removed child nodes.

The check is done before the local item states are connected to their shared states, which means getAddedChildNodes() will always return the complete list of local child nodes. In addition the merge attempt is also done after the check, which means it is impossible to handle concurrently removed child nodes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-2577) SISM.checkAddedChildNodes() prevents merging of concurrent changes

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger resolved JCR-2577.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0

Committed patch in revision: 926324

> SISM.checkAddedChildNodes() prevents merging of concurrent changes
> ------------------------------------------------------------------
>
>                 Key: JCR-2577
>                 URL: https://issues.apache.org/jira/browse/JCR-2577
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.0.0
>            Reporter: Marcel Reutegger
>             Fix For: 2.1.0
>
>         Attachments: JCR-2577.patch
>
>
> This is a regression caused by JCR-2456. The check method reports false positives and prevents merges of concurrently removed child nodes.
> The check is done before the local item states are connected to their shared states, which means getAddedChildNodes() will always return the complete list of local child nodes. In addition the merge attempt is also done after the check, which means it is impossible to handle concurrently removed child nodes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2577) SISM.checkAddedChildNodes() prevents merging of concurrent changes

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-2577:
-------------------------------

    Fix Version/s: 2.0.1

Merged to the 2.0 branch in revision 936672.

> SISM.checkAddedChildNodes() prevents merging of concurrent changes
> ------------------------------------------------------------------
>
>                 Key: JCR-2577
>                 URL: https://issues.apache.org/jira/browse/JCR-2577
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.0.0
>            Reporter: Marcel Reutegger
>             Fix For: 2.0.1, 2.1.0
>
>         Attachments: JCR-2577.patch
>
>
> This is a regression caused by JCR-2456. The check method reports false positives and prevents merges of concurrently removed child nodes.
> The check is done before the local item states are connected to their shared states, which means getAddedChildNodes() will always return the complete list of local child nodes. In addition the merge attempt is also done after the check, which means it is impossible to handle concurrently removed child nodes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2577) SISM.checkAddedChildNodes() prevents merging of concurrent changes

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger updated JCR-2577:
----------------------------------

    Attachment: JCR-2577.patch

Proposed patch

> SISM.checkAddedChildNodes() prevents merging of concurrent changes
> ------------------------------------------------------------------
>
>                 Key: JCR-2577
>                 URL: https://issues.apache.org/jira/browse/JCR-2577
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.0.0
>            Reporter: Marcel Reutegger
>         Attachments: JCR-2577.patch
>
>
> This is a regression caused by JCR-2456. The check method reports false positives and prevents merges of concurrently removed child nodes.
> The check is done before the local item states are connected to their shared states, which means getAddedChildNodes() will always return the complete list of local child nodes. In addition the merge attempt is also done after the check, which means it is impossible to handle concurrently removed child nodes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2577) SISM.checkAddedChildNodes() prevents merging of concurrent changes

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-2577:
-------------------------------

    Fix Version/s: core 1.4.12
                   1.6.2

Merged to the 1.6 and 1.4 branches in revisions 948500 and 948501.

> SISM.checkAddedChildNodes() prevents merging of concurrent changes
> ------------------------------------------------------------------
>
>                 Key: JCR-2577
>                 URL: https://issues.apache.org/jira/browse/JCR-2577
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.0.0
>            Reporter: Marcel Reutegger
>             Fix For: core 1.4.12, 1.6.2, 2.0.1, 2.1.0
>
>         Attachments: JCR-2577.patch
>
>
> This is a regression caused by JCR-2456. The check method reports false positives and prevents merges of concurrently removed child nodes.
> The check is done before the local item states are connected to their shared states, which means getAddedChildNodes() will always return the complete list of local child nodes. In addition the merge attempt is also done after the check, which means it is impossible to handle concurrently removed child nodes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.