You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by ad...@apache.org on 2023/05/03 14:04:29 UTC

[fineract] branch revert-3146-FINERACT-1724/reload_entity_during_cob created (now 85c0159c5)

This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a change to branch revert-3146-FINERACT-1724/reload_entity_during_cob
in repository https://gitbox.apache.org/repos/asf/fineract.git


      at 85c0159c5 Revert "FINERACT-1724: Fix entity reload logic of COB"

This branch includes the following new commits:

     new 85c0159c5 Revert "FINERACT-1724: Fix entity reload logic of COB"

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[fineract] 01/01: Revert "FINERACT-1724: Fix entity reload logic of COB"

Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch revert-3146-FINERACT-1724/reload_entity_during_cob
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit 85c0159c5944c63827c20890d74944c8c4e7b55c
Author: Adam Saghy <ad...@gmail.com>
AuthorDate: Wed May 3 16:04:21 2023 +0200

    Revert "FINERACT-1724: Fix entity reload logic of COB"
    
    This reverts commit 5fe708a90feb3c022f7835386d045aaa18cf7d89.
---
 .../org/apache/fineract/cob/service/LoanReloadService.java     | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanReloadService.java b/fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanReloadService.java
index d661bf6a0..4e86b0d01 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanReloadService.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanReloadService.java
@@ -18,19 +18,17 @@
  */
 package org.apache.fineract.cob.service;
 
-import javax.persistence.EntityManager;
-import javax.persistence.PersistenceContext;
 import lombok.RequiredArgsConstructor;
 import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
 import org.apache.fineract.portfolio.loanaccount.domain.Loan;
+import org.apache.fineract.portfolio.loanaccount.service.LoanAssembler;
 import org.springframework.stereotype.Component;
 
 @Component
 @RequiredArgsConstructor
 public class LoanReloadService implements ReloadService<Loan> {
 
-    @PersistenceContext
-    private EntityManager entityManager;
+    private final LoanAssembler loanAssembler;
 
     @Override
     public <S extends AbstractPersistableCustom> boolean canReload(S input) {
@@ -39,9 +37,7 @@ public class LoanReloadService implements ReloadService<Loan> {
 
     @Override
     public Loan reload(Loan input) {
-        entityManager.flush();
-        entityManager.refresh(input);
-        return input;
+        return loanAssembler.assembleFrom(input.getId());
     }
 
 }