You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Erik Hatcher <er...@ehatchersolutions.com> on 2009/06/23 03:25:53 UTC

Re: svn commit: r787205 - in /lucene/solr/trunk/contrib/dataimporthandler: CHANGES.txt src/main/java/org/apache/solr/handler/dataimport/DataImportHandler.java src/main/java/org/apache/solr/handler/dataimport/SolrWriter.java

On Jun 22, 2009, at 7:27 AM, noble@apache.org wrote:
> Author: noble
> Date: Mon Jun 22 11:27:53 2009
> New Revision: 787205
>
> URL: http://svn.apache.org/viewvc?rev=787205&view=rev
> Log:
> 36.SOLR-1234: Multiple DIH does not work because all of them write  
> to dataimport.properties. Use the handler name as the properties  
> file name

Are there any issues with folks upgrading and delta queries having  
issues because it's looking for a different .properties file?

> +          if(name.startsWith("/")){
> +            myName = name.substring(1);
> +          }

Note that request handler mappings can be with more than just a  
leading slash.  This needs to be adjusted to replace all slashes with  
underscore or something like that.  For example, in our latest project  
we're using /indexer/articles as the DIH mapping for one source.

An alternative is to use a single dataimport.properties file and look  
for keys based on the request handler mapping name.

I'm going to re-open this issue to let the multiple-slash issue get  
resolved.

	Erik


Re: svn commit: r787205 - in /lucene/solr/trunk/contrib/dataimporthandler: CHANGES.txt src/main/java/org/apache/solr/handler/dataimport/DataImportHandler.java src/main/java/org/apache/solr/handler/dataimport/SolrWriter.java

Posted by Noble Paul നോബിള്‍ नोब्ळ् <no...@corp.aol.com>.
using single properties file is error prone. They are not synchronized
and writes may happen at anytime

On Tue, Jun 23, 2009 at 6:55 AM, Erik Hatcher<er...@ehatchersolutions.com> wrote:
>
> On Jun 22, 2009, at 7:27 AM, noble@apache.org wrote:
>>
>> Author: noble
>> Date: Mon Jun 22 11:27:53 2009
>> New Revision: 787205
>>
>> URL: http://svn.apache.org/viewvc?rev=787205&view=rev
>> Log:
>> 36.SOLR-1234: Multiple DIH does not work because all of them write to
>> dataimport.properties. Use the handler name as the properties file name
>
> Are there any issues with folks upgrading and delta queries having issues
> because it's looking for a different .properties file?
>
>> +          if(name.startsWith("/")){
>> +            myName = name.substring(1);
>> +          }
>
> Note that request handler mappings can be with more than just a leading
> slash.  This needs to be adjusted to replace all slashes with underscore or
> something like that.  For example, in our latest project we're using
> /indexer/articles as the DIH mapping for one source.
>
> An alternative is to use a single dataimport.properties file and look for
> keys based on the request handler mapping name.
>
> I'm going to re-open this issue to let the multiple-slash issue get
> resolved.
>
>        Erik
>
>



-- 
-----------------------------------------------------
Noble Paul | Principal Engineer| AOL | http://aol.com