You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@crunch.apache.org by "Allan Shoup (JIRA)" <ji...@apache.org> on 2014/08/12 20:35:12 UTC

[jira] [Updated] (CRUNCH-446) Add null checks for DoFn fields

     [ https://issues.apache.org/jira/browse/CRUNCH-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allan Shoup updated CRUNCH-446:
-------------------------------

    Attachment: CRUNCH-446.3.patch

Added patch 3. This patch goes back to the less-invasive original patch with two additional fixes cited in [my previous comment|https://issues.apache.org/jira/browse/CRUNCH-446?focusedCommentId=14065466&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14065466].

> Add null checks for DoFn fields
> -------------------------------
>
>                 Key: CRUNCH-446
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-446
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Allan Shoup
>            Priority: Minor
>         Attachments: CRUNCH-446.2.patch, CRUNCH-446.3.patch, CRUNCH-446.patch
>
>
> DoFn.getConfiguration() gracefully handles the fields being null, but most other methods do not. Adding null checks around all field access within DoFn would make it easier for consumers to write tests for their own function classes because they would not be required to set the context, for instance.



--
This message was sent by Atlassian JIRA
(v6.2#6252)