[GitHub] ivankelly opened a new pull request #1850: Ship git info in jar and print at boot

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #1850: Ship git info in jar and print at boot
URL: https://github.com/apache/incubator-pulsar/pull/1850
 
 
   We currently print the version at boot. However, there's no guarantee
   that modifications haven't been made against that version without the
   version string being bumped. The only why to be sure is to have the
   git sha that the jar was built from.
   
   This patch packages the git information into a properties file, which
   is shipped in the jar. It requires git to be available on the PATH to
   work. If not, the file is not generated, but the build does not fail.
   
   The version printing on boot has been moved to the start of the
   PulsarService#start() method, and now prints the version as before,
   but also the git sha, the git user and email of the builder, the
   machine it was built on and the time it was built.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services