You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/08/06 08:01:52 UTC
Review Request 68216: Updated `volume/image` isolator to honor volume
mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814
Repository: mesos
Description
-------
Updated `volume/image` isolator to honor volume mode.
Diffs
-----
src/slave/containerizer/mesos/isolators/volume/image.hpp 706b8ff28e1b1c8d15606d54d40622bc09885667
src/slave/containerizer/mesos/isolators/volume/image.cpp 345772439b73b4816f71e15bb4e43a5d67c51c02
Diff: https://reviews.apache.org/r/68216/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68216: Updated `volume/image` isolator to honor
volume mode.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/#review207269
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 13, 2018, 11:28 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68216/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 11:28 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `volume/image` isolator to honor volume mode.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/image.hpp 706b8ff28e1b1c8d15606d54d40622bc09885667
> src/slave/containerizer/mesos/isolators/volume/image.cpp 345772439b73b4816f71e15bb4e43a5d67c51c02
>
>
> Diff: https://reviews.apache.org/r/68216/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68216: Updated `volume/image` isolator to honor
volume mode.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/
-----------------------------------------------------------
(Updated Aug. 14, 2018, 2:28 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Addressed review comments.
Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814
Repository: mesos
Description
-------
Updated `volume/image` isolator to honor volume mode.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/volume/image.hpp 706b8ff28e1b1c8d15606d54d40622bc09885667
src/slave/containerizer/mesos/isolators/volume/image.cpp 345772439b73b4816f71e15bb4e43a5d67c51c02
Diff: https://reviews.apache.org/r/68216/diff/3/
Changes: https://reviews.apache.org/r/68216/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68216: Updated `volume/image` isolator to honor
volume mode.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/#review207180
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/volume/image.cpp
Lines 117 (patched)
<https://reviews.apache.org/r/68216/#comment290478>
Given we already parse the volume once in prepare(), should we consider avoid parse it again in _prepare() and pass a vector of bool along?
- Gilbert Song
On Aug. 7, 2018, 7:20 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68216/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 7:20 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `volume/image` isolator to honor volume mode.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/image.hpp 706b8ff28e1b1c8d15606d54d40622bc09885667
> src/slave/containerizer/mesos/isolators/volume/image.cpp 345772439b73b4816f71e15bb4e43a5d67c51c02
>
>
> Diff: https://reviews.apache.org/r/68216/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68216: Updated `volume/image` isolator to honor
volume mode.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/
-----------------------------------------------------------
(Updated Aug. 7, 2018, 10:20 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814
Repository: mesos
Description
-------
Updated `volume/image` isolator to honor volume mode.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/volume/image.hpp 706b8ff28e1b1c8d15606d54d40622bc09885667
src/slave/containerizer/mesos/isolators/volume/image.cpp 345772439b73b4816f71e15bb4e43a5d67c51c02
Diff: https://reviews.apache.org/r/68216/diff/2/
Changes: https://reviews.apache.org/r/68216/diff/1-2/
Testing
-------
Thanks,
Qian Zhang