[jira] [Commented] (OOZIE-998) test-patch doesn't allow lines that are exactly 132 characters

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459777#comment-13459777 ] 

Hadoop QA commented on OOZIE-998:
---------------------------------

Testing JIRA OOZIE-998

Cleaning local svn workspace

{code}
----------------------------

+1 PATCH_APPLIES
   CLEAN cleaned target directories
+1 RAW_PATCH_ANALYSIS
    +1 the patch does not introduce any @author tags
    +1 the patch does not introduce any tabs
    +1 the patch does not introduce any trailing spaces
    +1 the patch does not introduce any line longer than 132
    +1 the patch does adds/modifies 1 testcase(s)
+1 RAT
    +1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
    +1 the patch does not seem to introduce new Javadoc warnings
+1 COMPILE
    +1 HEAD compiles
    +1 patch compiles
    +1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
    +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
    +1 the patch does not modify JPA files
+1 TESTS
   Tests run: 910
   Tests failures: 0
   Tests errors: 0
+1 DISTRO
    +1 distro tarball builds with the patch 

----------------------------
{code}

The full output of the test-patch run is available at

   https://builds.apache.org/job/oozie-trunk-precommit-build/106/
                
> test-patch doesn't allow lines that are exactly 132 characters
> --------------------------------------------------------------
>
>                 Key: OOZIE-998
>                 URL: https://issues.apache.org/jira/browse/OOZIE-998
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Trivial
>         Attachments: OOZIE-998.patch
>
>
> The test-patch does the following to check for lines longer than 132 characters:
> {code}longLines=`grep "^+ " ${PATCHFILE} | awk 'BEGIN{count=0}{if ( length > 132 ) { count=count+1} }END{ print count}'`{code}
> However, each line is actually one character longer than it would be once applied because of the {{+}} sign, so test-patch currently won't allow lines that are exactly 132 characters.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira