You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/05/19 21:21:01 UTC
[GitHub] [netbeans] eirikbakke opened a new pull request #2965: [NETBEANS-5697] Various smaller LAF/HiDPI improvements in the Windows LAF
eirikbakke opened a new pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965
This PR includes a few smaller improvements that were made to the Windows LAF while working on modernized tab components. Summary:
- Apply previous border tweaks for HiDPI screens in a few more places, notably in tooltips and the quick search text field, and in the editor toolbar. Improve JSpinner borders.
- Make the background color of tooltips consistent with that of other Windows 10 apps.
- Add some pixels of left margin to the editor toolbar.
- Also apply the workarounds from NETBEANS-3592 to JCheckboxMenuItem and friends. This fixes the following problem:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #2965: [NETBEANS-5697] Various smaller LAF/HiDPI improvements in the Windows LAF
Posted by GitBox <gi...@apache.org>.
DevCharly commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-846984556
You could also remove bottom (and top?) separator of the main toolbar:
It is created here:
https://github.com/apache/netbeans/blob/dd5eb0d56e742e3a2e1c3566d64c0f20e78bee0b/platform/core.windows/src/org/netbeans/core/windows/view/ui/toolbars/ToolbarConfiguration.java#L621-L634
Looking at that code it actually seems to be a bug that the toolbar has top and bottom borders on Windows 10, because it does not have borders on Windows 8...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2965: [NETBEANS-5697] Various LAF/HiDPI improvements on Windows
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-881953858
This looks like a sane change, has positive reviews, does not introduce a revolution and seems to pretty much contained and is tested. I suggest to get this in now.
@eirikbakke minor comment for the future: I would add the issue marker to the commit messages themselves - its the individual commits, that are shown when running `git blame` (or the using the corresponding netbeans action) and it would make it easier to find the issue that motivated a change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #2965: [NETBEANS-5697] Various LAF/HiDPI improvements on Windows
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-851212561
I added another commit with more improvements around the toolbar and menu bar area, including the proposed border change. Here is the latest look, with the newest changes annotated, at 150% HiDPI scaling:
Here is the same window at 100% HiDPI scaling, without the annotations:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #2965: [NETBEANS-5697] Various smaller LAF/HiDPI improvements in the Windows LAF
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-849054877
Good idea, will try it... (in fact, I think I already removed that border in my own NetBeans Platform application)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #2965: [NETBEANS-5697] Various LAF/HiDPI improvements on Windows
Posted by GitBox <gi...@apache.org>.
DevCharly commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-852276930
that looks much better 👍
I think you can remove method `ToolbarConfiguration.isWindows8()`. Seems to be unused now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #2965: [NETBEANS-5697] Various LAF/HiDPI improvements on Windows
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-880190583
I did a force push just to remove the now-unused ToolbarConfiguration.isWindows8() method, as earlier suggested. Other than that I think the discussion items were resolved here (judging by rasa-app's thumbs-up emoji :-).
I have used this patch in my working IDE and platform app for two months, so I think it should be safe to merge (once Travis passes again)...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #2965: [NETBEANS-5697] Various LAF/HiDPI improvements on Windows
Posted by GitBox <gi...@apache.org>.
geertjanw merged pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #2965: [NETBEANS-5697] Various LAF/HiDPI improvements on Windows
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-853095328
Here's a mockup with a line under the toolbar, without adding spacing:
I don't think the line works very well here. It makes things look too cramped--alternatively it will require more margin to be added back around the toolbar, which consumes precious vertical space. Alternatively, different background colors don't look consistent; it's kind of like using too many fonts in a text document. Plus, whenever there's a change in the background color you need additional margin.
(On the topic of "change in background color", I also experimented with making the menu bar grey, or the toolbar white, to avoid the change between the menu bar and the toolbar. But the menu bar is always white on Windows 10, and a white toolbar looked odd.)
I do understand what you mean by "irregularity" with the space next to the tabs. But most of the time this will be filled up by tabs, so the typical appearance of the IDE won't have this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rasa-app commented on pull request #2965: [NETBEANS-5697] Various LAF/HiDPI improvements on Windows
Posted by GitBox <gi...@apache.org>.
rasa-app commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-852831693
IMHO, removing bottom border of toolbar completely, causes a kind of irregularity because toolbar icons messing with other icons, I think it's better to remove just shadows and keep a simple border or just like FlatLaf, make the toolbar background a little darker or lighter and make a distinguish between toolbar and other parts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #2965: [NETBEANS-5697] Various LAF/HiDPI improvements on Windows
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #2965:
URL: https://github.com/apache/netbeans/pull/2965#issuecomment-881965176
Thanks! @matthiasblaesing Sure, I will reference the issue in each individual commit message in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists