You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/22 11:36:12 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue #10920: Refactor SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES statement with shardingsphere-integration-test
strongduanmu opened a new issue #10920:
URL: https://github.com/apache/shardingsphere/issues/10920
Hi community,
This issue is for #10887.
# Background
Currently `FederateStatementTest` and `FederatePrepareStatementTest` use JUNIT to test SQL statements. In order to improve test coverage and code elegance, we need to migrate the test scenarios of FederateStatementTest and FederatePrepareStatementTest to `shardingsphere-integration-test`.
# Target
The goal of this issue is to migrate the `SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES` statement to the `shardingsphere-integration-test` module.
You can search for the `SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES` keyword, and then you will find the test cases in `FederateStatementTest` and `FederatePrepareStatementTest`.
FederateStatementTest:
```java
private static final String SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES =
"select o.order_id_sharding, i.order_id from t_order_federate_sharding o, t_order_item_federate_sharding i "
+ "where o.order_id_sharding = i.item_id";
@Test
public void assertQueryWithFederateBetweenTwoShardingTablesByExecuteQuery() throws SQLException {
assertQueryWithFederateBetweenTwoShardingTables(true);
}
@Test
public void assertQueryWithFederateBetweenTwoShardingTablesByExecute() throws SQLException {
assertQueryWithFederateBetweenTwoShardingTables(false);
}
private void assertQueryWithFederateBetweenTwoShardingTables(final boolean executeQuery) throws SQLException {
ShardingSphereStatement statement = (ShardingSphereStatement) getShardingSphereDataSource().getConnection().createStatement();
ResultSet resultSet = getResultSet(statement, SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES, executeQuery);
assertNotNull(resultSet);
assertTrue(resultSet.next());
assertThat(resultSet.getInt(1), is(1010));
assertThat(resultSet.getInt(2), is(10001));
assertTrue(resultSet.next());
assertThat(resultSet.getInt(1), is(1011));
assertThat(resultSet.getInt(2), is(10001));
assertFalse(resultSet.next());
}
```
FederatePrepareStatementTest:
```java
private static final String SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES =
"select o.order_id_sharding, i.order_id from t_order_federate_sharding o, t_order_item_federate_sharding i "
+ "where o.order_id_sharding = i.item_id and i.order_id > ?";
@Test
public void assertQueryWithFederateBetweenTwoShardingTablesByExecuteQuery() throws SQLException {
assertQueryWithFederateBetweenTwoShardingTables(true);
}
@Test
public void assertQueryWithFederateBetweenTwoShardingTablesByExecute() throws SQLException {
assertQueryWithFederateBetweenTwoShardingTables(false);
}
private void assertQueryWithFederateBetweenTwoShardingTables(final boolean executeQuery) throws SQLException {
ShardingSpherePreparedStatement preparedStatement = (ShardingSpherePreparedStatement) getShardingSphereDataSource()
.getConnection().prepareStatement(SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES);
preparedStatement.setInt(1, 10000);
ResultSet resultSet = getResultSet(preparedStatement, executeQuery);
assertNotNull(resultSet);
assertTrue(resultSet.next());
assertThat(resultSet.getInt(1), is(1010));
assertThat(resultSet.getInt(2), is(10001));
assertTrue(resultSet.next());
assertThat(resultSet.getInt(1), is(1011));
assertThat(resultSet.getInt(2), is(10001));
assertFalse(resultSet.next());
}
```
# How to
In order to finish this task, you need to understand the [documentation](https://shardingsphere.apache.org/document/current/en/features/test-engine/integration-test/) of the integration test first, and PR #10913 also provides an example, which you can refer to. BTW, if you have any questions, please leave a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #10920: Refactor SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES statement with shardingsphere-integration-test
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10920:
URL: https://github.com/apache/shardingsphere/issues/10920#issuecomment-904346043
Please assign it to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #10920: Refactor SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES statement with shardingsphere-integration-test
Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #10920:
URL: https://github.com/apache/shardingsphere/issues/10920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #10920: Refactor SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES statement with shardingsphere-integration-test
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #10920:
URL: https://github.com/apache/shardingsphere/issues/10920#issuecomment-904355302
@LeeGuoPing Assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #10920: Refactor SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES statement with shardingsphere-integration-test
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10920:
URL: https://github.com/apache/shardingsphere/issues/10920#issuecomment-905312291
@strongduanmu I have finished it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #10920: Refactor SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES statement with shardingsphere-integration-test
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10920:
URL: https://github.com/apache/shardingsphere/issues/10920#issuecomment-905075424
@strongduanmu I have a question, which env should I do, can I add tbl env only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #10920: Refactor SELECT_SQL_BY_ID_ACROSS_TWO_SHARDING_TABLES statement with shardingsphere-integration-test
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #10920:
URL: https://github.com/apache/shardingsphere/issues/10920#issuecomment-905093008
> @strongduanmu I have a question, which env should I do, can I add tbl env only?
@LeeGuoPing You only need to use two non-binding sharding tables in the sharding scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org