You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/24 07:24:09 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1827: Fix intermittent failure of AHC-WS itest
jamesnetherton opened a new pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827
Fixes #1815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1827: Fix intermittent failure of AHC-WS itest
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1827: Fix intermittent failure of AHC-WS itest
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1827: Fix intermittent failure of AHC-WS itest
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827#discussion_r494112065
##########
File path: integration-tests/http/src/main/java/org/apache/camel/quarkus/component/http/it/GreetingServerEndpoint.java
##########
@@ -16,14 +16,34 @@
*/
package org.apache.camel.quarkus.component.http.it;
+import javax.websocket.OnClose;
import javax.websocket.OnMessage;
+import javax.websocket.OnOpen;
+import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;
+import org.jboss.logging.Logger;
+
@ServerEndpoint("/ahc-ws/greeting")
public class GreetingServerEndpoint {
+ public static boolean connected = false;
Review comment:
Shouldn't this be volatile? HttpResource.java is going to read it from a different thread and it would be better it if gets a non-cached value, wouldn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1827: Fix intermittent failure of AHC-WS itest
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827#issuecomment-698225243
Merging as test failure is not related to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1827: Fix intermittent failure of AHC-WS itest
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827#discussion_r494118199
##########
File path: integration-tests/http/src/main/java/org/apache/camel/quarkus/component/http/it/GreetingServerEndpoint.java
##########
@@ -16,14 +16,34 @@
*/
package org.apache.camel.quarkus.component.http.it;
+import javax.websocket.OnClose;
import javax.websocket.OnMessage;
+import javax.websocket.OnOpen;
+import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;
+import org.jboss.logging.Logger;
+
@ServerEndpoint("/ahc-ws/greeting")
public class GreetingServerEndpoint {
+ public static boolean connected = false;
Review comment:
Yeah, you're right. Latest commit fixes that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1827: Fix intermittent failure of AHC-WS itest
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827#discussion_r494118199
##########
File path: integration-tests/http/src/main/java/org/apache/camel/quarkus/component/http/it/GreetingServerEndpoint.java
##########
@@ -16,14 +16,34 @@
*/
package org.apache.camel.quarkus.component.http.it;
+import javax.websocket.OnClose;
import javax.websocket.OnMessage;
+import javax.websocket.OnOpen;
+import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;
+import org.jboss.logging.Logger;
+
@ServerEndpoint("/ahc-ws/greeting")
public class GreetingServerEndpoint {
+ public static boolean connected = false;
Review comment:
Yeah, you're right. Latest commit fixes that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1827: Fix intermittent failure of AHC-WS itest
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827#discussion_r494112065
##########
File path: integration-tests/http/src/main/java/org/apache/camel/quarkus/component/http/it/GreetingServerEndpoint.java
##########
@@ -16,14 +16,34 @@
*/
package org.apache.camel.quarkus.component.http.it;
+import javax.websocket.OnClose;
import javax.websocket.OnMessage;
+import javax.websocket.OnOpen;
+import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;
+import org.jboss.logging.Logger;
+
@ServerEndpoint("/ahc-ws/greeting")
public class GreetingServerEndpoint {
+ public static boolean connected = false;
Review comment:
Shouldn't this be volatile? HttpResource.java is going to read it from a different thread and it would be better it if gets a non-cached value, wouldn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1827: Fix intermittent failure of AHC-WS itest
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1827:
URL: https://github.com/apache/camel-quarkus/pull/1827#issuecomment-698225243
Merging as test failure is not related to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org