[jira] [Commented] (THRIFT-1615) Thrift for Symfony 2

["Xavier HAUSHERR (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287285#comment-13287285 ] 

Xavier HAUSHERR commented on THRIFT-1615:
-----------------------------------------

I am totally agree with you. 
But in this case, are you ok remove the "oop" and "namespace" options too ?

Because namespace is only for > PHP 5.3, and then, generating non-oop or non-namespaced classes became useless ?

What is your opinion on that point ?
                
> Thrift for Symfony 2
> --------------------
>
>                 Key: THRIFT-1615
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1615
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler, PHP - Library
>    Affects Versions: 0.8, 0.9
>            Reporter: Xavier HAUSHERR
>              Labels: improvement, php, symfony2
>             Fix For: 0.8, 0.9
>
>         Attachments: thrift-0.8.x-phpsf2.patch, thrift-trunk-phpsf2.patch
>
>
> Hi,
> In order to use Thrift with the Framework Symfony 2 and its great ClassLoader, I have:
> namespaced your PHP Lib (phpsf2)
> added an option sf2 to the PHP compiler. The main differences, are the use of namespace, and remove your autloader.
> I have done this in the 0.8x branch (stable version) and in your trunk.
> I use it with a Symfony bundle I create to have a cool integration in Symfony 2. Here is the git: git@github.com:ebuzzing/OverblogThriftBundle.git
> Feel free to send me any question, any feedback on my pull request.
> Best regards.
> Xavier HAUSHERR
> Overblog CTO
> @xkobal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira