You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/07/23 22:59:17 UTC

[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for nullifzero and zeroifnull

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11024


Change subject: IMPALA-5839: [DOCS] Corrected the return types for nullifzero and zeroifnull
......................................................................

IMPALA-5839: [DOCS] Corrected the return types for nullifzero and zeroifnull

Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
---
M docs/topics/impala_conditional_functions.xml
1 file changed, 19 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11024/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Gerrit-Change-Number: 11024
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11024 )

Change subject: IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO
......................................................................

IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
---
M docs/topics/impala_conditional_functions.xml
1 file changed, 19 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11024/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Gerrit-Change-Number: 11024
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11024 )

Change subject: IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Gerrit-Change-Number: 11024
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 18:46:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11024 )

Change subject: IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/358/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Gerrit-Change-Number: 11024
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 18:56:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11024 )

Change subject: IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO
......................................................................

IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Reviewed-on: http://gerrit.cloudera.org:8080/11024
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_conditional_functions.xml
1 file changed, 19 insertions(+), 18 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Gerrit-Change-Number: 11024
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11024 )

Change subject: IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Gerrit-Change-Number: 11024
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 19:01:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11024 )

Change subject: IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO
......................................................................


Patch Set 2:

Hi Phil,
Could you review this short change? Or if you recommend another reviewer, please add the reviewer. 
Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/11024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Gerrit-Change-Number: 11024
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 20:06:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11024 )

Change subject: IMPALA-5839: [DOCS] Corrected the return types for NULLIFZERO and NULLIFZERO
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7927a5caf1d200a1f4d04d3729c29391c7f43cd
Gerrit-Change-Number: 11024
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 18:56:45 +0000
Gerrit-HasComments: No