[GitHub] [incubator-hudi] leesf commented on issue #1062: [HUDI-294] Delete Paths written in Cleaner plan needs to be relative to partition-path

[GitBox <gi...@apache.org>]

leesf commented on issue #1062: [HUDI-294] Delete Paths written in Cleaner plan needs to be relative to partition-path
URL: https://github.com/apache/incubator-hudi/pull/1062#issuecomment-560960177
 
 
   > Thanks @leesf : This is a good starting point. You would need to make further changes in
   > 
   > 1. HoodieCleanHelper.getDeletePaths need to return only relative paths.
   > 2. HoodieCopyOnWriteTable.scheduleClean to return only relative paths.
   > 3. (1) and (2) will ensure HoodieCleanClient.scheduleClean will store cleaner plans with relative paths.
   > 4. IncrementalTimelineSyncFileSystemView.addCleanInstant needs to handle relative partition paths
   
   Hi @bvaradar . Currently the `HoodieCleanHelper.getDeletePaths` (point 1) and `HoodieCopyOnWriteTable.scheduleClean` (point 2) return relative path already. Also the currently `IncrementalTimelineSyncFileSystemView.addCleanInstant` only handles relative path. Please correct me if I am wrong.
   
   And I addressed other comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services