[GitHub] [incubator-druid] clintropolis commented on a change in pull request #5872: add method getRequiredColumns for DimFilter

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #5872: add method getRequiredColumns for DimFilter
URL: https://github.com/apache/incubator-druid/pull/5872#discussion_r310786713
 
 

 ##########
 File path: processing/src/main/java/io/druid/query/filter/DimFilter.java
 ##########
 @@ -75,4 +77,9 @@
    * determine for this DimFilter.
    */
   RangeSet<String> getDimensionRangeSet(String dimension);
+
+  /**
+   * @return a HashSet that represents all columns' name which the DimFilter required to do filter.
+   */
+  HashSet<String> getRequiredColumns();
 
 Review comment:
   I'm making this change to use `Set` as part of #8209.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org