You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/15 00:23:11 UTC
[GitHub] [gobblin] autumnust commented on a change in pull request #3311: [GOBBLIN-1472] toggle to control compaction MR output dir
autumnust commented on a change in pull request #3311:
URL: https://github.com/apache/gobblin/pull/3311#discussion_r651356303
##########
File path: gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -249,6 +250,10 @@ protected boolean configureInputAndOutputPaths(Job job, FileSystemDataset datase
CompactionPathParser.CompactionParserResult rst = parser.parse(dataset);
this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(), rst.getDstSubDir(), rst.getTimeString());
+ if(this.state.contains(ConfigurationKeys.USE_DATASET_LOCAL_WORK_DIR)) {
+ mrOutputBase = this.state.getProp(MRCompactor.COMPACTION_DEST_DIR);
+ this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(), ConfigurationKeys.TMP_DIR, rst.getDstSubDir(), rst.getTimeString());
Review comment:
Seems too long a line, did you use the style file in https://gobblin.readthedocs.io/en/latest/developer-guide/CodingStyle/ ?
##########
File path: gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -241,6 +241,7 @@ protected void addJars(Configuration conf, State state, FileSystem fs) throws IO
* a directory containing one or more files.
*
*/
+
Review comment:
Can we remove this blank line ?
##########
File path: gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -249,6 +250,10 @@ protected boolean configureInputAndOutputPaths(Job job, FileSystemDataset datase
CompactionPathParser.CompactionParserResult rst = parser.parse(dataset);
this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(), rst.getDstSubDir(), rst.getTimeString());
Review comment:
Can we rewrite this block as a ternary expression instead of having the value of `mrOutputPath` to be bind twice if the condition in the line 253 hold?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org