You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by "Dag H. Wanvik (JIRA)" <ji...@apache.org> on 2013/04/18 08:43:16 UTC

[jira] [Commented] (DERBY-6186) SYSTRIGGERSRowFactory should use DataDescriptorGenerator to build descriptor

    [ https://issues.apache.org/jira/browse/DERBY-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634902#comment-13634902 ] 

Dag H. Wanvik commented on DERBY-6186:
--------------------------------------

+1, net improvement. Thanks.
                
> SYSTRIGGERSRowFactory should use DataDescriptorGenerator to build descriptor
> ----------------------------------------------------------------------------
>
>                 Key: DERBY-6186
>                 URL: https://issues.apache.org/jira/browse/DERBY-6186
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Trivial
>         Attachments: derby-6186-01-a.diff
>
>
> SYSTRIGGERSRowFactory.buildDescriptor() creates a descriptor by calling TriggerDescriptor's constructor directly. It already has a DataDescriptorGenerator instance, so it should instead call the newTriggerDescriptor(). This would allow TriggerDescriptor's constructor to become package protected, which improves encapsulation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira