You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Federico Fanton (JIRA)" <ji...@apache.org> on 2008/08/11 09:43:47 UTC

[jira] Created: (WICKET-1786) Adding SVG support detection to ClientProperties

Adding SVG support detection to ClientProperties
------------------------------------------------

                 Key: WICKET-1786
                 URL: https://issues.apache.org/jira/browse/WICKET-1786
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3.4
         Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / IE7 (without plugins)
            Reporter: Federico Fanton
            Priority: Minor
         Attachments: detect_svg.patch

I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1786) Adding SVG support detection to ClientProperties

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1786.
-----------------------------------

    Resolution: Won't Fix

had to roll it back, just noticed that the detectSVG.js is licensed under CC attribution, which is incompatible with our ASF2

© Copyright 2008 Tanrei Software, Licensed under the CC Attribution License
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> Adding SVG support detection to ClientProperties
> ------------------------------------------------
>
>                 Key: WICKET-1786
>                 URL: https://issues.apache.org/jira/browse/WICKET-1786
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>         Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / IE7 (without plugins)
>            Reporter: Federico Fanton
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.5, 1.4-M4
>
>         Attachments: detect_svg.patch
>
>
> I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/ ), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1786) Adding SVG support detection to ClientProperties

Posted by "Federico Fanton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Federico Fanton updated WICKET-1786:
------------------------------------

    Attachment: detect_svg.patch

Here's the patch

> Adding SVG support detection to ClientProperties
> ------------------------------------------------
>
>                 Key: WICKET-1786
>                 URL: https://issues.apache.org/jira/browse/WICKET-1786
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>         Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / IE7 (without plugins)
>            Reporter: Federico Fanton
>            Priority: Minor
>         Attachments: detect_svg.patch
>
>
> I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1786) Adding SVG support detection to ClientProperties

Posted by "Federico Fanton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Federico Fanton updated WICKET-1786:
------------------------------------

    Description: 
I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/ ), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
Thanks!

  was:
I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
Thanks!


> Adding SVG support detection to ClientProperties
> ------------------------------------------------
>
>                 Key: WICKET-1786
>                 URL: https://issues.apache.org/jira/browse/WICKET-1786
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>         Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / IE7 (without plugins)
>            Reporter: Federico Fanton
>            Priority: Minor
>         Attachments: detect_svg.patch
>
>
> I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/ ), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1786) Adding SVG support detection to ClientProperties

Posted by "Federico Fanton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635126#action_12635126 ] 

Federico Fanton commented on WICKET-1786:
-----------------------------------------

Sorry, I didn't think to check for licenses outside of the code :/

> Adding SVG support detection to ClientProperties
> ------------------------------------------------
>
>                 Key: WICKET-1786
>                 URL: https://issues.apache.org/jira/browse/WICKET-1786
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>         Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / IE7 (without plugins)
>            Reporter: Federico Fanton
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.5, 1.4-M4
>
>         Attachments: detect_svg.patch
>
>
> I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/ ), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1786) Adding SVG support detection to ClientProperties

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1786.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-M4
                   1.3.5
         Assignee: Igor Vaynberg

> Adding SVG support detection to ClientProperties
> ------------------------------------------------
>
>                 Key: WICKET-1786
>                 URL: https://issues.apache.org/jira/browse/WICKET-1786
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>         Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / IE7 (without plugins)
>            Reporter: Federico Fanton
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.5, 1.4-M4
>
>         Attachments: detect_svg.patch
>
>
> I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/ ), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1786) Adding SVG support detection to ClientProperties

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1786:
---------------------------------------

    Fix Version/s:     (was: 1.4-RC1)
                       (was: 1.3.5)

> Adding SVG support detection to ClientProperties
> ------------------------------------------------
>
>                 Key: WICKET-1786
>                 URL: https://issues.apache.org/jira/browse/WICKET-1786
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>         Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / IE7 (without plugins)
>            Reporter: Federico Fanton
>            Assignee: Igor Vaynberg
>            Priority: Minor
>         Attachments: detect_svg.patch
>
>
> I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/ ), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-1786) Adding SVG support detection to ClientProperties

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reopened WICKET-1786:
-----------------------------------


> Adding SVG support detection to ClientProperties
> ------------------------------------------------
>
>                 Key: WICKET-1786
>                 URL: https://issues.apache.org/jira/browse/WICKET-1786
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.4
>         Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / IE7 (without plugins)
>            Reporter: Federico Fanton
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.5, 1.4-M4
>
>         Attachments: detect_svg.patch
>
>
> I'd like to extend BrowserInfoForm to detect if the browser supports SVGs (javascript method here http://thomas.tanrei.ca/modern-script-based-svg-detection/ ), but it looks like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 (hope it's not too messy ^^; )
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.