You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "petern48 (via GitHub)" <gi...@apache.org> on 2025/05/02 01:55:39 UTC

[PR] Website: Add PyIceberg, IcebergRust, and IcebergGo to top nav bar [iceberg]

petern48 opened a new pull request, #12950:
URL: https://github.com/apache/iceberg/pull/12950

   Closes #12910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Website: Add PyIceberg, IcebergRust, and IcebergGo to top nav bar [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12950: Website: Add PyIceberg, IcebergRust, and IcebergGo to top nav bar
URL: https://github.com/apache/iceberg/pull/12950


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Website: Add PyIceberg, IcebergRust, and IcebergGo to top nav bar [iceberg]

Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #12950:
URL: https://github.com/apache/iceberg/pull/12950#issuecomment-2908385299

   @petern48 Thanks, I've [opened a discussion on the dev list](https://lists.apache.org/thread/ndmtzdjwzw5tjs47zg5owphx0p3pzqv1) for a more comprehensive restructure of the side navigation.  Let's see what others think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Website: Add PyIceberg, IcebergRust, and IcebergGo to top nav bar [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12950:
URL: https://github.com/apache/iceberg/pull/12950#issuecomment-3006593593

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Website: Add PyIceberg, IcebergRust, and IcebergGo to top nav bar [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12950:
URL: https://github.com/apache/iceberg/pull/12950#issuecomment-3029789921

   This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Website: Add PyIceberg, IcebergRust, and IcebergGo to top nav bar [iceberg]

Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 commented on PR #12950:
URL: https://github.com/apache/iceberg/pull/12950#issuecomment-2869936552

   I experimented with trying to achieve what the Spark docs do (as you requested [here](https://github.com/apache/iceberg/issues/12910#issuecomment-2855028749)) by nesting the docs inside a new nav bar field using the below change, and it does NOT create a dropdown. Instead, it just sends you directly to the PyIceberg website (the first entry), making the rest of the links inaccessible. I did some research, and it seems not all mkdoc themes support dropdowns, unfortunately.
   ```
   nav:
     ...
     - Other:
       - PyIceberg: https://py.iceberg.apache.org/
       - IcebergRust: https://rust.iceberg.apache.org/
       - IcebergGo: https://pkg.go.dev/github.com/apache/iceberg-go/
   ```
   
   Instead, I propose that we instead nest them under the existing `Docs` nav bar entry in the following way. Here's what the new code changes looks like.
   
   ![image](https://github.com/user-attachments/assets/c87bf50e-4d1e-468f-bd89-6a906907e863)
   
   Expanding the "Iceberg" section, we can then see what was previously in the `Docs` nav bar item.
   ![image](https://github.com/user-attachments/assets/50dae3ad-7e00-42de-b735-51c6547e6d7f)
   
   When you originally click on `Docs` at the top, it defaults to the first page entry (Iceberg -> nightly -> Introduction) as before. What do you think @manuzhang?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org