You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2019/06/06 19:54:42 UTC

[Impala-ASF-CR] Fix integration of kudu-hive.jar

Hello Hao Hao, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13542

to look at the new patch set (#2).

Change subject: Fix integration of kudu-hive.jar
......................................................................

Fix integration of kudu-hive.jar

IMPALA-8503 added downloading kudu-hive.jar and adding it to
HADOOP_CLASSPATH in run-hive-server.sh to allow the Hive Metastore to
start with Kudu's HMS plugin.

There are two problems with this that are fixed by this patch:
- Previously, we fully specify the expected jar filename based on the
  value of IMPALA_KUDU_JAVA_VERSION when adding it to HADOOP_CLASSPATH
  but this is overly restrictive for users who may wish to override
  this value in impala-config-branch.sh to build their own branch with
  a different version of the kudu-hive.jar This patch relaxes this
  restriction by adding any jar containing the string kudu-hive in
  IMPALA_KUDU_JAVA_HOME to HADOOP_CLASSPATH
- In bootstrap_toolchain, we don't download a package if its directory
  already exists. Since the 'kudu' and 'kudu-java' packages download
  to the same directory, this led to a race condition where
  'kudu-java' might not be downloaded if 'kudu' had already been
  unpacked when it started. This patch fixes this by inspecting the
  contents of the Kudu package directory to look for specific files
  expected for each Kudu package.

Change-Id: I4ac79c3e9b8625ba54145dba23c69fd5117f35c7
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M testdata/bin/run-hive-server.sh
3 files changed, 23 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/13542/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ac79c3e9b8625ba54145dba23c69fd5117f35c7
Gerrit-Change-Number: 13542
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>