You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nlpcraft.apache.org by "Aaron Radzinski (Jira)" <ji...@apache.org> on 2020/11/23 22:10:00 UTC

[jira] [Created] (NLPCRAFT-179) Fix license header/comment per mentor's suggestions.

Aaron Radzinski created NLPCRAFT-179:
----------------------------------------

             Summary: Fix license header/comment per mentor's suggestions.
                 Key: NLPCRAFT-179
                 URL: https://issues.apache.org/jira/browse/NLPCRAFT-179
             Project: NLPCraft
          Issue Type: Task
          Components: server
            Reporter: Aaron Radzinski
            Assignee: Aaron Radzinski
             Fix For: 0.7.3


{color:#222222}For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE and{color}
{color:#222222}NOTICE, thanks) if the statement "Code almost entirely based on work of{color}
{color:#222222}..." is indeed true, then I believe it is usually clearer to leave the{color}
{color:#222222}original license header in the source file and perhaps amend with{color}
{color:#222222}"Subsequent changes Copyright by the NLPCraft team and made under the{color}
{color:#222222}ASLv2..." but what you have is possibly okay - just not as clear. IANAL,{color}
{color:#222222}but my understanding is that you have the obligation to make it clear that{color}
{color:#222222}the requirements the original author requested for use of that file in{color}
{color:#222222}source form etc. are still in play and aren't overwritten by slapping the{color}
{color:#222222}ASLv2 header at the front of the file.{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)