You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/30 08:58:08 UTC
[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5912: arch/risc-v/mpfs: Remove duplicated riscv_restorefpu
pussuw commented on a change in pull request #5912:
URL: https://github.com/apache/incubator-nuttx/pull/5912#discussion_r838280401
##########
File path: arch/risc-v/src/mpfs/mpfs_irq_dispatch.c
##########
@@ -149,9 +142,6 @@ void *riscv_dispatch_irq(uintptr_t vector, uintptr_t *regs)
group_addrenv(NULL);
#endif
}
-#endif
-
-#endif
Review comment:
I think one too many #ifdefs got removed. The build fails now (CI)
##########
File path: arch/risc-v/src/mpfs/mpfs_irq_dispatch.c
##########
@@ -149,9 +142,6 @@ void *riscv_dispatch_irq(uintptr_t vector, uintptr_t *regs)
group_addrenv(NULL);
#endif
}
-#endif
-
-#endif
Review comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org