[GitHub] [flink] twalthr commented on a change in pull request #19137: [FLINK-26518][table] Support BridgingSqlFunction with SqlTableFunction for Scala implicits

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #19137:
URL: https://github.com/apache/flink/pull/19137#discussion_r831236217



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkRelBuilder.java
##########
@@ -105,6 +116,55 @@ public static RelBuilderFactory proto(Context context) {
         };
     }
 
+    /**
+     * {@link RelBuilder#functionScan(SqlOperator, int, Iterable)} cannot work smoothly with aliases
+     * which is why we implement a custom one. The method is static because some {@link RelOptRule}s
+     * doesn't use {@link FlinkRelBuilder}.
+     */
+    @SuppressWarnings({"rawtypes", "unchecked"})
+    public static RelBuilder pushFunctionScan(
+            RelBuilder relBuilder,
+            SqlOperator operator,
+            int inputCount,
+            Iterable<? extends RexNode> operands,

Review comment:
       it was necessary in the first PoC but now it isn't anymore :) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org