You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/15 06:25:55 UTC
[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #232:
feat(callback): use start pointer to manager callbacks
ShannonDing opened a new pull request #232: feat(callback): use start pointer to manager callbacks
URL: https://github.com/apache/rocketmq-client-cpp/pull/232
## What is the purpose of the change
feat(callback): use start pointer to manager callbacks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ifplusor edited a comment on issue #232:
feat(callback): use start pointer to manager callbacks
Posted by GitBox <gi...@apache.org>.
ifplusor edited a comment on issue #232: feat(callback): use start pointer to manager callbacks
URL: https://github.com/apache/rocketmq-client-cpp/pull/232#issuecomment-574554174
I think use unique_ptr is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ifplusor edited a comment on issue #232:
feat(callback): use start pointer to manager callbacks
Posted by GitBox <gi...@apache.org>.
ifplusor edited a comment on issue #232: feat(callback): use start pointer to manager callbacks
URL: https://github.com/apache/rocketmq-client-cpp/pull/232#issuecomment-574554174
I think smart pointer is unnecessary, and unique_ptr is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #232:
feat(callback): use start pointer to manager callbacks
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #232: feat(callback): use start pointer to manager callbacks
URL: https://github.com/apache/rocketmq-client-cpp/pull/232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ifplusor commented on issue #232:
feat(callback): use start pointer to manager callbacks
Posted by GitBox <gi...@apache.org>.
ifplusor commented on issue #232: feat(callback): use start pointer to manager callbacks
URL: https://github.com/apache/rocketmq-client-cpp/pull/232#issuecomment-574554174
I think smart pointer is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services