You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "cnabro (via GitHub)" <gi...@apache.org> on 2023/06/26 07:12:26 UTC
[GitHub] [superset] cnabro opened a new pull request, #24510: fix(dashboard): increase json_metadata field
cnabro opened a new pull request, #24510:
URL: https://github.com/apache/superset/pull/24510
### SUMMARY
- Data too long for column `json_metadata`
- Default column size is 65535, we need to increase column size for saving dashboard.
- position_json already changed to `utils.MediumText`
```
(MySQLdb._exceptions.DataError) (1406, "Data too long for column 'json_metadata' at row 1")
[SQL: UPDATE dashboards SET changed_on=%s, json_metadata=%s, changed_by_fk=%s WHERE dashboards.id = %s]
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
```sql
ALTER TABLE dashboards MODIFY json_metadata MEDIUMTEXT;
```
- After modifying the column, it works normally.
### ADDITIONAL INFORMATION
- [x] Has associated issue: https://github.com/apache/superset/issues/5532
- [ ] Required feature flags:
- [ ] Changes UI
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24510: fix(dashboard): increase json_metadata field
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24510:
URL: https://github.com/apache/superset/pull/24510#issuecomment-1631130413
Thanks @cnabro. You'll have to bump the `Revies/down_revision` since the latest version has changed. It tends to be somewhat of a race to get in line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cnabro commented on pull request #24510: fix(dashboard): increase json_metadata field
Posted by "cnabro (via GitHub)" <gi...@apache.org>.
cnabro commented on PR #24510:
URL: https://github.com/apache/superset/pull/24510#issuecomment-1612317266
I'd fixed alembic multiple head issues.
```
83e1abbe777f -> bf646a0c1501 (head), json_metadata
ae58e1e58e5c -> 83e1abbe777f, drop access_request
4c5da39be729 -> ae58e1e58e5c, migrate_dual_line_to_mixed_chart
9ba2ce3086e5 -> 4c5da39be729, migrate_treemap_chart
4ea966691069 -> 9ba2ce3086e5, migrate-pivot-table-v1-to-v2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24510: fix(dashboard): increase json_metadata field
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24510:
URL: https://github.com/apache/superset/pull/24510#issuecomment-1646833286
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24510?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24510](https://app.codecov.io/gh/apache/superset/pull/24510?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9e909eb) into [master](https://app.codecov.io/gh/apache/superset/commit/0631a8086cd95f3b6e88b31d29c7fbc2e1d20b25?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0631a80) will **decrease** coverage by `10.71%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 9e909eb differs from pull request most recent head fecb457. Consider uploading reports for the commit fecb457 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24510 +/- ##
===========================================
- Coverage 68.95% 58.25% -10.71%
===========================================
Files 1902 1902
Lines 73939 73939
Branches 8176 8176
===========================================
- Hits 50984 43070 -7914
- Misses 20842 28756 +7914
Partials 2113 2113
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `54.03% <100.00%> (ø)` | |
| python | `60.96% <100.00%> (-22.39%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.96% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://app.codecov.io/gh/apache/superset/pull/24510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `48.04% <100.00%> (-29.69%)` | :arrow_down: |
... and [292 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24510/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24510: fix(dashboard): increase json_metadata field
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24510:
URL: https://github.com/apache/superset/pull/24510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cnabro commented on pull request #24510: fix(dashboard): increase json_metadata field
Posted by "cnabro (via GitHub)" <gi...@apache.org>.
cnabro commented on PR #24510:
URL: https://github.com/apache/superset/pull/24510#issuecomment-1610503002
@john-bodley OK, I'll add table migration for dashboards 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24510: fix(dashboard): increase json_metadata field
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24510:
URL: https://github.com/apache/superset/pull/24510#issuecomment-1609893882
Thanks @cnabro for the PR. Would you mind also adding a database migration as without the migration this change has no impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cnabro commented on pull request #24510: fix(dashboard): increase json_metadata field
Posted by "cnabro (via GitHub)" <gi...@apache.org>.
cnabro commented on PR #24510:
URL: https://github.com/apache/superset/pull/24510#issuecomment-1630978832
@john-bodley Is there anything else to do to get a review? 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cnabro commented on pull request #24510: fix(dashboard): increase json_metadata field
Posted by "cnabro (via GitHub)" <gi...@apache.org>.
cnabro commented on PR #24510:
URL: https://github.com/apache/superset/pull/24510#issuecomment-1646832399
@john-bodley Thank you for guiding!
I'd bumped upstream master branch.
```
(venv) ~/private/superset fix/json_metadata ± superset db history
a23c6f8b1280 -> bf646a0c1501 (head), json_metadata
863adcf72773 -> a23c6f8b1280, cleanup erroneous parent filter IDs
6d05b0a70c89 -> 863adcf72773, delete obsolete Druid NoSQL slice parameters
f92a3124dd66 -> 6d05b0a70c89, add on delete cascade for owners references
240d23c7f86f -> f92a3124dd66, drop rouge constraints and tables
8e5b0fb85b9a -> 240d23c7f86f, update_tag_model_w_description
6fbe660cac39 -> 8e5b0fb85b9a, Add custom size columns to report schedule
90139bf715e4 -> 6fbe660cac39, add on delete cascade for tables references
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org