You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Ovilia (via GitHub)" <gi...@apache.org> on 2024/11/06 07:55:21 UTC

Re: [PR] feat(legend): add legendmouseover legendmouseout event (#18144) [echarts]

Ovilia commented on code in PR #18164:
URL: https://github.com/apache/echarts/pull/18164#discussion_r1830534724


##########
src/component/legend/legendAction.ts:
##########
@@ -37,6 +37,9 @@ function legendSelectActionHandler(methodName, payload, ecModel) {
         else if (methodName === 'allSelect' || methodName === 'inverseSelect') {
             legendModel[methodName]();
         }
+        else if (methodName === 'legendMouseover' || methodName === 'legendMouseout') {
+            isSelected = legendModel.isSelected(payload.name);

Review Comment:
   This is perhaps no longer needed. You make merge the current master code and have a double check.



##########
src/component/legend/legendAction.ts:
##########
@@ -37,6 +37,9 @@ function legendSelectActionHandler(methodName, payload, ecModel) {
         else if (methodName === 'allSelect' || methodName === 'inverseSelect') {
             legendModel[methodName]();
         }
+        else if (methodName === 'legendMouseover' || methodName === 'legendMouseout') {
+            isSelected = legendModel.isSelected(payload.name);

Review Comment:
   You should update the `LegendSelectMethodNames` after merging from master.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org