You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lybeen <gi...@git.apache.org> on 2017/07/26 08:45:55 UTC
[GitHub] incubator-weex pull request #541: + [android] add newNestedInstance method i...
GitHub user lybeen opened a pull request:
https://github.com/apache/incubator-weex/pull/541
+ [android] add newNestedInstance method in WXSDKInstance
add newNestedInstance method in WXSDKInstance, thus SubClass can instance custom nested WXSDKInstance in WXEmbed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lybeen/incubator-weex android-feature-addNewNestedInstance
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/541.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #541
----
commit bf9fe0dc284e7ba3881b2e6701127ce08572bdb5
Author: lybeen <il...@gmail.com>
Date: 2017-07-26T08:42:38Z
+ [android] add newNestedInstance method in WXSDKInstance
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #541: + [android] add newNestedInstance method i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #541: + [android] add newNestedInstance method in WXSDK...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/541
<!--
1 failure: This PR modify SD...
3 warning: No Changelog chan..., This PR should up..., Potential BREAK C...
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---