You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Suman Karumuri <sk...@twitter.com> on 2013/12/14 02:08:10 UTC
Review Request 16267: Adding a script to run an isolated scheduler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Repository: aurora
Description
-------
Adding a script to run an isolated scheduler.
Diffs
-----
examples/scheduler/scheduler-isolated.sh PRE-CREATION
Diff: https://reviews.apache.org/r/16267/diff/
Testing
-------
gradle clean build installApp && ./examples/scheduler/scheduler-isolated.sh works.
Thanks,
Suman Karumuri
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30472
-----------------------------------------------------------
examples/scheduler/scheduler-isolated.sh
<https://reviews.apache.org/r/16267/#comment58294>
license header is missing
examples/scheduler/scheduler-isolated.sh
<https://reviews.apache.org/r/16267/#comment58295>
Usage string is not particularly helpful, consider dropping
examples/scheduler/scheduler-isolated.sh
<https://reviews.apache.org/r/16267/#comment58292>
Can you remove the middle-man variable and just assign these all below?
examples/scheduler/scheduler-isolated.sh
<https://reviews.apache.org/r/16267/#comment58293>
Please look into using ./gradlew run instead
- Bill Farner
On Dec. 14, 2013, 1:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 1:08 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> examples/scheduler/scheduler-isolated.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean build installApp && ./examples/scheduler/scheduler-isolated.sh works.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Suman Karumuri <ma...@apache.org>.
> On Dec. 24, 2013, 12:32 a.m., Kevin Sweeney wrote:
> > build.gradle, lines 242-256
> > <https://reviews.apache.org/r/16267/diff/2/?file=402903#file402903line242>
> >
> > Can this list be pared down further?
This is the minimal list I could do. Anything more needs code changes.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30844
-----------------------------------------------------------
On Dec. 23, 2013, 11:19 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2013, 11:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean run
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30844
-----------------------------------------------------------
Ship it!
Ship It!
build.gradle
<https://reviews.apache.org/r/16267/#comment59043>
Can this list be pared down further?
- Kevin Sweeney
On Dec. 23, 2013, 3:19 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2013, 3:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean run
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Suman Karumuri <ma...@apache.org>.
> On Dec. 26, 2013, 8:25 p.m., Bill Farner wrote:
> > I agree with Kevin that reducing the arg count would be nice, but a quick scan makes me think this might be the minimal set today.
Thanks queued!
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30885
-----------------------------------------------------------
On Dec. 23, 2013, 11:19 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2013, 11:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean run
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30885
-----------------------------------------------------------
Ship it!
I agree with Kevin that reducing the arg count would be nice, but a quick scan makes me think this might be the minimal set today.
- Bill Farner
On Dec. 23, 2013, 11:19 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2013, 11:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean run
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/
-----------------------------------------------------------
(Updated Dec. 23, 2013, 11:19 p.m.)
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Changes
-------
Removed the shell script. Repurposing run target to run a local scheduler since run is unused right now.
gradle clean run
to run a local scheduler.
Repository: aurora
Description
-------
Adding a script to run an isolated scheduler.
Diffs (updated)
-----
build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
Diff: https://reviews.apache.org/r/16267/diff/
Testing (updated)
-------
gradle clean run
Thanks,
Suman Karumuri
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Suman Karumuri <sk...@twitter.com>.
> On Dec. 14, 2013, 1:30 a.m., Bill Farner wrote:
> > I would much rather see further investment in local runs through vagrant. Have you considered focusing there instead?
Yes, I have considered it and found vagrant to be too slow for iterative edit-build-run cycle. I prefer a local script like this for local testing. Kevin also suggested that I not go the vagrant route for the same reason.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30394
-----------------------------------------------------------
On Dec. 14, 2013, 1:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 1:08 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> examples/scheduler/scheduler-isolated.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean build installApp && ./examples/scheduler/scheduler-isolated.sh works.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Suman Karumuri <su...@gmail.com>.
> On Dec. 14, 2013, 1:30 a.m., Bill Farner wrote:
> > I would much rather see further investment in local runs through vagrant. Have you considered focusing there instead?
>
> Suman Karumuri wrote:
> Yes, I have considered it and found vagrant to be too slow for iterative edit-build-run cycle. I prefer a local script like this for local testing. Kevin also suggested that I not go the vagrant route for the same reason.
>
> Zameer Manji wrote:
> Have we considered improving vagrant so it is suitable for an iterative edit-build-run cycle? That is fairly normal amongst other projects that use Vagrant.
Once I found vagrant to be a slower option, I have not looked into it further for the following reasons:
a) Such an option doesn't provide any more value than a simple shell script like this at least for UI testing.
b) Even with vagrant in place, it will be nice to have some way to run to run a local scheduler without depending on vagrant or other things like this.
c) It is simpler to attach a debugger to a running process when the process is running on a local host than when it is running inside a VM.
d) When things don't work, vagrant is another layer to peel through to understand whatever is going on.
e) This script follows the same dev workflow as before and I see no reason to change it.
f) Making vagrant better for this use case, seemed like embarking on another yak shaving trip.
In short, keeping it simple. I also felt that a simple script like this makes the ramp up time for new devs lower.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30394
-----------------------------------------------------------
On Dec. 14, 2013, 1:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 1:08 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> examples/scheduler/scheduler-isolated.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean build installApp && ./examples/scheduler/scheduler-isolated.sh works.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Zameer Manji <zm...@gmail.com>.
> On Dec. 13, 2013, 5:30 p.m., Bill Farner wrote:
> > I would much rather see further investment in local runs through vagrant. Have you considered focusing there instead?
>
> Suman Karumuri wrote:
> Yes, I have considered it and found vagrant to be too slow for iterative edit-build-run cycle. I prefer a local script like this for local testing. Kevin also suggested that I not go the vagrant route for the same reason.
Have we considered improving vagrant so it is suitable for an iterative edit-build-run cycle? That is fairly normal amongst other projects that use Vagrant.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30394
-----------------------------------------------------------
On Dec. 13, 2013, 5:08 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 5:08 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> examples/scheduler/scheduler-isolated.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean build installApp && ./examples/scheduler/scheduler-isolated.sh works.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Longbin Chen <lb...@gmail.com>.
+1 for local run
On Fri, Dec 13, 2013 at 5:30 PM, Bill Farner <wf...@apache.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/#review30394
> -----------------------------------------------------------
>
>
> I would much rather see further investment in local runs through vagrant.
> Have you considered focusing there instead?
>
> - Bill Farner
>
>
> On Dec. 14, 2013, 1:08 a.m., Suman Karumuri wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/16267/
> > -----------------------------------------------------------
> >
> > (Updated Dec. 14, 2013, 1:08 a.m.)
> >
> >
> > Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill
> Farner.
> >
> >
> > Repository: aurora
> >
> >
> > Description
> > -------
> >
> > Adding a script to run an isolated scheduler.
> >
> >
> > Diffs
> > -----
> >
> > examples/scheduler/scheduler-isolated.sh PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/16267/diff/
> >
> >
> > Testing
> > -------
> >
> > gradle clean build installApp &&
> ./examples/scheduler/scheduler-isolated.sh works.
> >
> >
> > Thanks,
> >
> > Suman Karumuri
> >
> >
>
>
Re: Review Request 16267: Adding a script to run an isolated scheduler.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16267/#review30394
-----------------------------------------------------------
I would much rather see further investment in local runs through vagrant. Have you considered focusing there instead?
- Bill Farner
On Dec. 14, 2013, 1:08 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16267/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 1:08 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a script to run an isolated scheduler.
>
>
> Diffs
> -----
>
> examples/scheduler/scheduler-isolated.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16267/diff/
>
>
> Testing
> -------
>
> gradle clean build installApp && ./examples/scheduler/scheduler-isolated.sh works.
>
>
> Thanks,
>
> Suman Karumuri
>
>