You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/03/31 19:25:03 UTC
Review Request 45551: GEODE-1031 and GEODE-1149 make sure client is
closing cache properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45551/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Darrel Schneider, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
GEODE-1031 Now pool closes queueMge before connectionMgr
At cache close, there is possibility that queueMgr is trying to
recover queue but cache/pool trying to close cache with keep-alive
false flag. During this time there is possibility that client(queueMgr)
may be unable to close socket properly as it doesn't know about
keep-alive flag. Thats why closing connectionMge after queueMgr
so that it should be able to send keep-alive flage properly
to server.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java 84debc8
Diff: https://reviews.apache.org/r/45551/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 45551: GEODE-1031 and GEODE-1149 make sure client
is closing cache properly
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45551/#review126361
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On March 31, 2016, 5:25 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45551/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 5:25 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Darrel Schneider, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1031 Now pool closes queueMge before connectionMgr
>
> At cache close, there is possibility that queueMgr is trying to
> recover queue but cache/pool trying to close cache with keep-alive
> false flag. During this time there is possibility that client(queueMgr)
> may be unable to close socket properly as it doesn't know about
> keep-alive flag. Thats why closing connectionMge after queueMgr
> so that it should be able to send keep-alive flage properly
> to server.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java 84debc8
>
> Diff: https://reviews.apache.org/r/45551/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 45551: GEODE-1031 and GEODE-1149 make sure client
is closing cache properly
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45551/#review126374
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On March 31, 2016, 10:25 a.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45551/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 10:25 a.m.)
>
>
> Review request for geode, Bruce Schuchardt, Darrel Schneider, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1031 Now pool closes queueMge before connectionMgr
>
> At cache close, there is possibility that queueMgr is trying to
> recover queue but cache/pool trying to close cache with keep-alive
> false flag. During this time there is possibility that client(queueMgr)
> may be unable to close socket properly as it doesn't know about
> keep-alive flag. Thats why closing connectionMge after queueMgr
> so that it should be able to send keep-alive flage properly
> to server.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java 84debc8
>
> Diff: https://reviews.apache.org/r/45551/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>