You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "strangelookingnerd (via GitHub)" <gi...@apache.org> on 2024/11/21 09:28:35 UTC
[PR] Migrate tests to JUnit5 [dubbo]
strangelookingnerd opened a new pull request, #14922:
URL: https://github.com/apache/dubbo/pull/14922
Most of the tests already use JUnit5. This PR will migrate the missing tests and remove the `junit-jupiter-vintage` as well as `junit` dependencies.
Migration includes:
* Using JUnit5 annotations
* Using `Assertions`
* Remove `public` modifiers from test classes and methods
* Clean up assertions (switching `expected` and `actual`, simplyifing assertions...)
* Trivial code cleanup
I validated my changes using `./build -t`.
## Checklist
- [ ] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](./CONTRIBUTING.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Migrate tests to JUnit5 [dubbo]
Posted by "wcy666103 (via GitHub)" <gi...@apache.org>.
wcy666103 commented on PR #14922:
URL: https://github.com/apache/dubbo/pull/14922#issuecomment-2490596858
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Migrate tests to JUnit5 [dubbo]
Posted by "strangelookingnerd (via GitHub)" <gi...@apache.org>.
strangelookingnerd commented on PR #14922:
URL: https://github.com/apache/dubbo/pull/14922#issuecomment-2491436233
> Test locally first.
Seems like I missed that one, sorry for that. However to me it seems like this test should have failed without my changes as well.
I noticed that there is an exact copy of the failing test which has the assertion that is causing the issue here is commented out
Comparing
[dubbo-spring-boot/src/test/java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest.java](https://github.com/strangelookingnerd/dubbo/blob/757dd4bfd73df36f9f9a85caa314a5b93a066efe/dubbo-spring-boot-project/dubbo-spring-boot/src/test/java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest.java#L58)
[dubbo-spring-boot-autoconfigure/src/test/java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest](https://github.com/strangelookingnerd/dubbo/blob/757dd4bfd73df36f9f9a85caa314a5b93a066efe/dubbo-spring-boot-project/dubbo-spring-boot-autoconfigure/src/test/java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest.java#L58)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Migrate tests to JUnit5 [dubbo]
Posted by "wcy666103 (via GitHub)" <gi...@apache.org>.
wcy666103 commented on PR #14922:
URL: https://github.com/apache/dubbo/pull/14922#issuecomment-2491230293
Test locally first.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Migrate tests to JUnit5 [dubbo]
Posted by "CrazyHZM (via GitHub)" <gi...@apache.org>.
CrazyHZM merged PR #14922:
URL: https://github.com/apache/dubbo/pull/14922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org