You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/16 12:49:14 UTC

[GitHub] [incubator-druid] leventov opened a new issue #8887: Make Transformer single-threaded and get rid of `rowSupplierForValueMatcher` ThreadLocal

leventov opened a new issue #8887: Make Transformer single-threaded and get rid of `rowSupplierForValueMatcher` ThreadLocal
URL: https://github.com/apache/incubator-druid/issues/8887
 
 
   `Transformer`'s `ThreadLocal rowSupplierForValueMatcher` doesn't need to be an instance field for the same reasons as `IncrementalIndex`'s `ThreadLocal in` field (see #8886). In the case of `Transformer`, it would be actually better to make it a single-threaded class right away and remove a `ThreadLocal` from inside `Transformer`, forcing users of the class to produce copies of `Transformer` per-task (worker, firehose, etc), if they need it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org