You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2018/10/12 16:06:00 UTC
[jira] [Commented] (IO-588) IOUtils.writeLines() should accept an
Iterable<>
[ https://issues.apache.org/jira/browse/IO-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648079#comment-16648079 ]
Gary Gregory commented on IO-588:
---------------------------------
[~lmartelli],
Thank you for your patch but... -1 to this patch as it breaks binary compatibility.
You can provide another patch that ADDs APIs, instead of changing the current ones in a way that breaks BC. You can probably delegate the Collection APIs to the new Iterable APIs. And provide tests ;)
Gary
> IOUtils.writeLines() should accept an Iterable<>
> ------------------------------------------------
>
> Key: IO-588
> URL: https://issues.apache.org/jira/browse/IO-588
> Project: Commons IO
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 2.6
> Reporter: Laurent Martelli
> Priority: Minor
> Attachments: ioutils.diff
>
>
> IOUtils.writeLines() methods should accept an Iterable<> instead of a Collection<>, since it does not use any method of Collection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [jira] [Commented] (IO-588) IOUtils.writeLines() should accept an Iterable<>
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Oct 31, 2018 at 7:39 AM Jochen Wiedmann <jo...@gmail.com>
wrote:
> On Fri, Oct 12, 2018 at 6:06 PM Gary Gregory (JIRA) <ji...@apache.org>
> wrote:
>
> > Thank you for your patch but... -1 to this patch as it breaks binary
> compatibility.
>
> Could you explain that, please? A Collection is, in particular, an
> Iterable, thus the compiler should use the new methods, instead, as
> far as I can tell.
>
You are talking about _source_ compatibility. Binary compatibility should
allow a new jar to replace the old one, this change breaks that capability.
Gary
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [jira] [Commented] (IO-588) IOUtils.writeLines() should accept an Iterable<>
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Fri, Oct 12, 2018 at 6:06 PM Gary Gregory (JIRA) <ji...@apache.org> wrote:
> Thank you for your patch but... -1 to this patch as it breaks binary compatibility.
Could you explain that, please? A Collection is, in particular, an
Iterable, thus the compiler should use the new methods, instead, as
far as I can tell.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org