[jira] [Created] (AMBARI-12753) Blueprints TopologyManager locking strategy should be re-designed

["Robert Nettleton (JIRA)" <ji...@apache.org>]

Robert Nettleton created AMBARI-12753:
-----------------------------------------

             Summary: Blueprints TopologyManager locking strategy should be re-designed
                 Key: AMBARI-12753
                 URL: https://issues.apache.org/jira/browse/AMBARI-12753
             Project: Ambari
          Issue Type: Bug
          Components: ambari-server
    Affects Versions: 2.1.0
            Reporter: Robert Nettleton
            Assignee: Robert Nettleton
            Priority: Critical
             Fix For: 2.2.0


The Blueprints TopologyManager class:

org.apache.ambari.server.topology.TopologyManager.java

uses several fine-grained locks, typically to manage the collections of hosts as reserved and incoming hosts are mapped to requests.  

A review for the patch for AMBARI-12720 showed that the locking strategy in the TopologyManager is generally too brittle, and is error-prone over the course of maintaining this code.

This bug tracks the investigation and possible work required to re-implement the locking strategies used in this class.  

There are several options that should be explored:

1. Locking at a coarse-grained level, perhaps at the level of the TopologyManager.
2. Replacing the existing locks with java.util.concurrent locks that can enable better performance by reducing lock contention. 





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)