You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Takashi Sato <ta...@lans-tv.com> on 2009/07/09 15:53:52 UTC
Including apu_version.h and APR 2.0
mod_info's new feature doesn't compile against apr/apr-util 1.3.x
/usr/home/test/httpd-trunk/modules/generators/mod_info.c: In function 'show_server_settings':
/usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: implicit declaration of function 'apu_version_string'
/usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: format '%s' expects type 'char *', but argument 3 has type 'int'
/usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: 'APU_VERSION_STRING' undeclared (first use in this function)
/usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: (Each undeclared identifier is reported only once
/usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: for each function it appears in.)
Include apu_version.h and this is fixed, but considering APR 2.0.....
apu_version.h does exist in APR 2.0, so we don't need to care APR version?
Or we should enclose it with #if APR_MAJOR_VERSION < 2 ?
Re: Including apu_version.h and APR 2.0
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
> Hi,
> Guenter Knauf schrieb:
>> I would prefer to stay with the '#ifdef APR_VERSION < 2' because they
>> cost us nothing, and at least at the moment it is possible to build
>> httpd-2.2.x with APR 2.0.0-dev - just tested with NetWare, and
>> absolutely no prob, compiles and runs.
> Surprisingly I've just found that we still have apu_version.h +
> apu_version() with APR-2.0.0-dev, and if we keep this in future then I
> even see no reason to ifdef mod_info in trunk ....
>
> Bill, do we keep apu_version.h with APR-2.x, or will it be removed?
> Maybe we can just:
> #define APU_VERSION APR_VERSION
> #define apu_version apr_version
>
> and have then a simple backward compat?
The issue is that 2.0 anticipates renaming all of the foo_ex functions back
to foo, discarding the old, insufficient interfaces. Another round of name
space review, normalizing inconsistent API's (why is the retval arg pointer
not the first arg to function x?) and so forth. Provided that is how the
apr members want to move forwards, consumers are likely to need to adjust
their sources, meaning that dropping apu_version may be a benefit, flag
that other changes are necessary.
Anyways, this list to suggest this is dev@apr.a.o, but it sounds like an
idea worth considering, especially during the transition.
Re: Including apu_version.h and APR 2.0
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
Guenter Knauf schrieb:
> I would prefer to stay with the '#ifdef APR_VERSION < 2' because they
> cost us nothing, and at least at the moment it is possible to build
> httpd-2.2.x with APR 2.0.0-dev - just tested with NetWare, and
> absolutely no prob, compiles and runs.
Surprisingly I've just found that we still have apu_version.h +
apu_version() with APR-2.0.0-dev, and if we keep this in future then I
even see no reason to ifdef mod_info in trunk ....
Bill, do we keep apu_version.h with APR-2.x, or will it be removed?
Maybe we can just:
#define APU_VERSION APR_VERSION
#define apu_version apr_version
and have then a simple backward compat?
Gün.
Re: Including apu_version.h and APR 2.0
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
William A. Rowe, Jr. schrieb:
> +1 for trunk, no need for httpd-2.2 - we will be breaking ABI and API at 2.0
> and won't expect httpd 2.2 to compile against it without significant change.
I would prefer to stay with the '#ifdef APR_VERSION < 2' because they
cost us nothing, and at least at the moment it is possible to build
httpd-2.2.x with APR 2.0.0-dev - just tested with NetWare, and
absolutely no prob, compiles and runs.
Gün.
Re: Including apu_version.h and APR 2.0
Posted by Takashi Sato <ta...@lans-tv.com>.
On Thu, 09 Jul 2009 09:06:52 -0500
"William A. Rowe, Jr." <wr...@rowe-clan.net> wrote:
> Takashi Sato wrote:
> > mod_info's new feature doesn't compile against apr/apr-util 1.3.x
> >
> > /usr/home/test/httpd-trunk/modules/generators/mod_info.c: In function 'show_server_settings':
> > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: implicit declaration of function 'apu_version_string'
> > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: format '%s' expects type 'char *', but argument 3 has type 'int'
> > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: 'APU_VERSION_STRING' undeclared (first use in this function)
> > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: (Each undeclared identifier is reported only once
> > /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: for each function it appears in.)
> >
> > Include apu_version.h and this is fixed, but considering APR 2.0.....
> > apu_version.h does exist in APR 2.0, so we don't need to care APR version?
> > Or we should enclose it with #if APR_MAJOR_VERSION < 2 ?
>
> +1 for trunk, no need for httpd-2.2 - we will be breaking ABI and API at 2.0
> and won't expect httpd 2.2 to compile against it without significant change.
>
Thanks,
I commited it to trunk (r792570)
and update patch for 2.2 (r792576)
Re: Including apu_version.h and APR 2.0
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Takashi Sato wrote:
> mod_info's new feature doesn't compile against apr/apr-util 1.3.x
>
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c: In function 'show_server_settings':
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: implicit declaration of function 'apu_version_string'
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: format '%s' expects type 'char *', but argument 3 has type 'int'
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: 'APU_VERSION_STRING' undeclared (first use in this function)
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: (Each undeclared identifier is reported only once
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366: error: for each function it appears in.)
>
> Include apu_version.h and this is fixed, but considering APR 2.0.....
> apu_version.h does exist in APR 2.0, so we don't need to care APR version?
> Or we should enclose it with #if APR_MAJOR_VERSION < 2 ?
+1 for trunk, no need for httpd-2.2 - we will be breaking ABI and API at 2.0
and won't expect httpd 2.2 to compile against it without significant change.
RE: Including apu_version.h and APR 2.0
Posted by "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>.
> -----Original Message-----
> From: Takashi Sato
> Sent: Donnerstag, 9. Juli 2009 15:54
> To: dev@httpd.apache.org
> Subject: Including apu_version.h and APR 2.0
>
> mod_info's new feature doesn't compile against apr/apr-util 1.3.x
>
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c: In
> function 'show_server_settings':
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:363:
> warning: implicit declaration of function 'apu_version_string'
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:363:
> warning: format '%s' expects type 'char *', but argument 3
> has type 'int'
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366:
> error: 'APU_VERSION_STRING' undeclared (first use in this function)
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366:
> error: (Each undeclared identifier is reported only once
> /usr/home/test/httpd-trunk/modules/generators/mod_info.c:366:
> error: for each function it appears in.)
>
> Include apu_version.h and this is fixed, but considering APR 2.0.....
> apu_version.h does exist in APR 2.0, so we don't need to care
> APR version?
> Or we should enclose it with #if APR_MAJOR_VERSION < 2 ?
As in the patch the last one. So include it conditional.
Regards
Rüdiger