You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/07/31 08:30:18 UTC
Review Request 36975: Support single-value/multi-line UI input for
policy condition values
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36975/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Madhan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-585
https://issues.apache.org/jira/browse/RANGER-585
Repository: ranger
Description
-------
For custom conditions (like IP-range, time-range) Ranger Admin policy editing UI allows users to enter multiple values. As user enters special characters like newline/semi-colon, subsequent input is taken as a new value. This UI should be updated to support conditions that expect a single value that can include these special characters.
Diffs
-----
security-admin/src/main/webapp/libs/bower/esprima/esprima.js PRE-CREATION
security-admin/src/main/webapp/scripts/Init.js a8acd0d
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 36a513e
security-admin/src/main/webapp/scripts/utils/XAUtils.js 00075dc
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js d6c9a97
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 332a1d9
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js bbb38f5
security-admin/src/main/webapp/templates/common/TopNav_tmpl.html 6b62ba3
Diff: https://reviews.apache.org/r/36975/diff/
Testing
-------
Tested implementation on local Ranger setup for policy conditions using javascript expressions for syntax erros and valid expressions.
Thanks,
Gautam Borad