You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:34:40 UTC

[GitHub] [hudi] vinothchandar commented on pull request #1871: [WIP] [HUDI-781] Introduce HoodieDataPrep for test preparation

vinothchandar commented on pull request #1871:
URL: https://github.com/apache/hudi/pull/1871#issuecomment-665363288


   On the DataPrep I was wondering through,
   if we should call it `HoodieTestTable` or something, since it's just creating some files, not really writing data. Also our code will probably generate 1,2 commits in most places. So should it include helpers like fakeTestTable.generateTwoCommits() etc. Idea here is to make test shorter. I am fine to just begin by standardizing though. 
   We should probably have another `HoodieTestTableWithData` which actually generates test table using regular writeClient APIs, does sanity asserts. and actually writes data into these files 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org