You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/11/30 12:38:00 UTC
[jira] [Commented] (LUCENE-9624) fix duplicate compute on
maxUnpatchedValue
[ https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240740#comment-17240740 ]
ASF subversion and git services commented on LUCENE-9624:
---------------------------------------------------------
Commit e6af255e67bde552a62f266a028e2b652cedc518 in lucene-solr's branch refs/heads/branch_8x from gf2121
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e6af255 ]
LUCENE-9624: fix duplicate compute on maxUnpatchedValue (#2106)
Co-authored-by: 郭峰 <gu...@bytedance.com>
> fix duplicate compute on maxUnpatchedValue
> ------------------------------------------
>
> Key: LUCENE-9624
> URL: https://issues.apache.org/jira/browse/LUCENE-9624
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Reporter: Feng Guo
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> in [LUCENE-9027|[https://github.com/apache/lucene-solr/pull/973]] lucene introduced SIMD to decode postings, which leaves a very small problem. i hope i can fix this as my first PR on this amazing project :).
> detail:
> {code:java}
> maxUnpatchedValue has already computed apache.lucene.codecs.lucene84.PForUtil#encode line 64
> final long maxUnpatchedValue = (1L << patchedBitsRequired) - 1;
> apache.lucene.codecs.lucene84.PForUtil#encode line 74
> but computed later again:
> if (longs[i] > (1L << patchedBitsRequired) - 1)...{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org