[GitHub] ibuenros commented on a change in pull request #2565: [GOBBLIN-693] Add ORC hive serde manager

[GitBox <gi...@apache.org>]

ibuenros commented on a change in pull request #2565: [GOBBLIN-693] Add ORC hive serde manager
URL: https://github.com/apache/incubator-gobblin/pull/2565#discussion_r261696977
 
 

 ##########
 File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveSerDeManager.java
 ##########
 @@ -79,7 +80,8 @@ protected HiveSerDeManager(State props) {
   public abstract boolean haveSameSchema(HiveRegistrationUnit unit1, HiveRegistrationUnit unit2) throws IOException;
 
   public enum Implementation {
-    AVRO(HiveAvroSerDeManager.class.getName());
+    AVRO(HiveAvroSerDeManager.class.getName()),
 
 Review comment:
   Should we use service providers instead of a hard-coded list of implementations? This prevents third parties from adding their own implementations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services