You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/04/27 22:02:03 UTC
[jira] [Created] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
FsConfig should use constants in CommonConfigurationKeys
--------------------------------------------------------
Key: HADOOP-7245
URL: https://issues.apache.org/jira/browse/HADOOP-7245
Project: Hadoop Common
Issue Type: Bug
Reporter: Tom White
Assignee: Tom White
Fix For: 0.22.0
In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029712#comment-13029712 ]
Eli Collins commented on HADOOP-7245:
-------------------------------------
Hey Tom,
The change in your patch looks good. Latest patch just updates two tests. I'll commit this if Hudson comes back OK.
Thanks,
Eli
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025981#comment-13025981 ]
Hadoop QA commented on HADOOP-7245:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477574/HADOOP-7245.patch
against trunk revision 1096988.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
-1 contrib tests. The patch failed contrib unit tests.
-1 system test framework. The patch failed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//console
This message is automatically generated.
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-7245:
------------------------------
Attachment: HADOOP-7245.patch
This patch changes FsConfig to use the constants defined in CommonConfigurationKeys and CommonConfigurationKeysPublic.
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029866#comment-13029866 ]
Hudson commented on HADOOP-7245:
--------------------------------
Integrated in Hadoop-Common-22-branch #44 (See [https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/44/])
HADOOP-7245. svn merge -c 1100044 from trunk
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029730#comment-13029730 ]
Eli Collins commented on HADOOP-7245:
-------------------------------------
+1
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7245:
--------------------------------
Status: Open (was: Patch Available)
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-7245:
------------------------------
Status: Patch Available (was: Open)
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7245:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've committed this to trunk and merged to 22. Thanks Tom!
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7245:
--------------------------------
Attachment: hadoop-7245-1.patch
Patch attached fixes the compilation errors in the S3 tests.
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029745#comment-13029745 ]
Hudson commented on HADOOP-7245:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #574 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/574/])
HADOOP-7245. FsConfig should use constants in CommonConfigurationKeys. Contributed by Tom White
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7245:
--------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029718#comment-13029718 ]
Hadoop QA commented on HADOOP-7245:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12478362/hadoop-7245-1.patch
against trunk revision 1100026.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//console
This message is automatically generated.
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7245) FsConfig should use constants in
CommonConfigurationKeys
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029889#comment-13029889 ]
Hudson commented on HADOOP-7245:
--------------------------------
Integrated in Hadoop-Common-trunk #680 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk/680/])
HADOOP-7245. FsConfig should use constants in CommonConfigurationKeys. Contributed by Tom White
> FsConfig should use constants in CommonConfigurationKeys
> --------------------------------------------------------
>
> Key: HADOOP-7245
> URL: https://issues.apache.org/jira/browse/HADOOP-7245
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.22.0
>
> Attachments: HADOOP-7245.patch, hadoop-7245-1.patch
>
>
> In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira