You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/31 06:26:54 UTC
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #727: e2e: optimize before_each function in scaffold
tokers commented on a change in pull request #727:
URL: https://github.com/apache/apisix-ingress-controller/pull/727#discussion_r739763696
##########
File path: test/e2e/scaffold/scaffold.go
##########
@@ -281,7 +282,9 @@ func (s *Scaffold) APISIXGatewayServiceEndpoint() string {
}
func (s *Scaffold) beforeEach() {
+ start := time.Now()
var err error
+ var wg sync.WaitGroup
Review comment:
Use var block.
```suggestion
var (
err error
wg sync.WaitGroup
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org