You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/03/22 06:13:07 UTC
Review Request 70266: Removed a lambda to simplify `__allocate()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70266/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Removed a lambda to simplify `__allocate()`.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp c9cf704f046c0f08131ac3f2fee54f4b649eabff
Diff: https://reviews.apache.org/r/70266/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70266: Removed a lambda to simplify `__allocate()`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On March 22, 2019, 9 a.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1725 (original), 1711-1712 (patched)
> > <https://reviews.apache.org/r/70266/diff/1/?file=2133270#file2133270line1725>
> >
> > Do we need to say tracked by the quota role sorter? The code shows this. Is there something important about it coming from the quota role sorter here that the reader needs to know? (e.g. since this is a quota role it must be tracked in the quota role sorter? won't it be also tracked in the regular role sorter though?)
I just wanted to emphasize that the `Reovocable` resources are not included here. I can remove the "tracked by the quota role sorter." part.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70266/#review213915
-----------------------------------------------------------
On March 21, 2019, 11:13 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70266/
> -----------------------------------------------------------
>
> (Updated March 21, 2019, 11:13 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed a lambda to simplify `__allocate()`.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp c9cf704f046c0f08131ac3f2fee54f4b649eabff
>
>
> Diff: https://reviews.apache.org/r/70266/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70266: Removed a lambda to simplify `__allocate()`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70266/#review213915
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.cpp
Line 1725 (original), 1711-1712 (patched)
<https://reviews.apache.org/r/70266/#comment300028>
Do we need to say tracked by the quota role sorter? The code shows this. Is there something important about it coming from the quota role sorter here that the reader needs to know? (e.g. since this is a quota role it must be tracked in the quota role sorter? won't it be also tracked in the regular role sorter though?)
- Benjamin Mahler
On March 22, 2019, 6:13 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70266/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 6:13 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed a lambda to simplify `__allocate()`.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp c9cf704f046c0f08131ac3f2fee54f4b649eabff
>
>
> Diff: https://reviews.apache.org/r/70266/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>