You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/05/10 05:39:45 UTC
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19967: [improve][broker] Add haProxyProtocolEnabled more description
michaeljmarshall commented on code in PR #19967:
URL: https://github.com/apache/pulsar/pull/19967#discussion_r1189380600
##########
conf/broker.conf:
##########
@@ -85,6 +85,7 @@ advertisedAddress=
# internalListenerName=
# Enable or disable the HAProxy protocol.
+# If true, the real IP addresses of consumers and producers can be obtained when getting topic statistics data.
Review Comment:
Real might be misleading here. I think the IP address is the remote IP address from the proxy's perspective? If you agree, I think we should clarify further to prevent confusion. This is relevant when traffic ingresses to the proxy through any kind of NAT. A good example is a kubernetes load balancer with `externalTrafficPolicy: cluster`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org