You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "iaorekhov-1980 (via GitHub)" <gi...@apache.org> on 2026/01/29 14:12:23 UTC
[PR] [enhance] (auth) add option to disable login with empty pass [doris]
iaorekhov-1980 opened a new pull request, #60372:
URL: https://github.com/apache/doris/pull/60372
### What problem does this PR solve?
This PR adds new configuration property **ldap_allow_empty_pass** to prohibit option for existing user to login into LDAP with empty password.
If **ldap_allow_empty_pass** in ldap.conf is not specified or specified as **true** - user can login with empty pass (existing behavior).
If **ldap_allow_empty_pass** specified as **false** - login attempt with empty password will be rejected with corresponding error message.
**Could you please include this PR into 4.x and 3.1.x branches, please!**
Issue Number: close #60353
Related PR: #xxx
Problem Summary:
Currently for existing user it is possible to login into LDAP with empty password.
New configuration property disables such option, but default behavior still allows to login without specified password.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Explain the behavior change -->
1. ldap.conf and LdapConfig.java - new configuration **ldap_allow_empty_pass** property with default value **true** to keep existing behavior as default
2. ErrorCode.java - specific error message for case with empty password was added
3. LdapAuthenticator.java and Auth.java - additional check was added to validate two conditions
3.1 user has specified empty password
3.2 property **ldap_allow_empty_pass** is **false** and doesn't allow to login with empty password
If both conditions met - authentication is failed and new error is returned.
4. LdapAuthenticatorTest.java - introduced new test method to validate existing behavior (without specified **ldap_allow_empty_pass** property or true) and new one (with **ldap_use_ssl** property specified to false) to check that login is still successful in first case and failed in the second one.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3870040139
# FE UT Coverage Report
Increment line coverage ` 50.00% (6/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60372_5ca3f3dbd77a6a27be7fbcb730efdc949c1a22a9/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60372_5ca3f3dbd77a6a27be7fbcb730efdc949c1a22a9/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3823215447
# FE Regression Coverage Report
Increment line coverage ` 8.33% (1/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60372_6ea7c8c998ec1172e13c20767d1f480cb66c8e83_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60372_6ea7c8c998ec1172e13c20767d1f480cb66c8e83_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3822624402
<details>
<summary>TPC-H: <b>Total hot run time: 31646 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6ea7c8c998ec1172e13c20767d1f480cb66c8e83, data reload: false
------ Round 1 ----------------------------------
q1 17610 5254 5023 5023
q2 2075 308 184 184
q3 10196 1421 744 744
q4 10207 821 319 319
q5 7548 2194 1865 1865
q6 204 187 150 150
q7 912 723 627 627
q8 9284 1395 1053 1053
q9 5221 4880 4812 4812
q10 6824 1964 1565 1565
q11 543 302 272 272
q12 343 374 227 227
q13 17787 4028 3235 3235
q14 240 239 222 222
q15 898 824 815 815
q16 698 675 607 607
q17 628 757 552 552
q18 6702 6378 6408 6378
q19 1256 982 624 624
q20 405 349 223 223
q21 2648 1954 1880 1880
q22 356 313 269 269
Total cold run time: 102585 ms
Total hot run time: 31646 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5300 5297 5308 5297
q2 258 328 259 259
q3 2163 2678 2255 2255
q4 1390 1743 1303 1303
q5 4410 4319 4390 4319
q6 211 184 141 141
q7 2284 2160 1974 1974
q8 2627 2390 2445 2390
q9 7513 7556 7659 7556
q10 2829 3101 2748 2748
q11 577 483 478 478
q12 690 746 601 601
q13 3828 4551 3606 3606
q14 299 330 304 304
q15 864 818 867 818
q16 674 722 700 700
q17 1111 1329 1349 1329
q18 8042 8009 7807 7807
q19 926 930 917 917
q20 2156 2169 1930 1930
q21 4513 4133 4028 4028
q22 590 537 520 520
Total cold run time: 53255 ms
Total hot run time: 51280 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3861307476
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3823395393
run nonCurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3818006690
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3870903696
<details>
<summary>ClickBench: <b>Total hot run time: 28.46 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5ca3f3dbd77a6a27be7fbcb730efdc949c1a22a9, data reload: false
query1 0.06 0.04 0.04
query2 0.10 0.04 0.05
query3 0.25 0.10 0.08
query4 1.60 0.10 0.11
query5 0.27 0.26 0.25
query6 1.17 0.69 0.68
query7 0.03 0.02 0.02
query8 0.05 0.04 0.04
query9 0.57 0.50 0.50
query10 0.54 0.55 0.54
query11 0.13 0.10 0.09
query12 0.14 0.10 0.10
query13 0.64 0.61 0.61
query14 1.05 1.04 1.06
query15 0.89 0.87 0.87
query16 0.40 0.40 0.42
query17 1.10 1.11 1.10
query18 0.23 0.22 0.21
query19 2.03 1.98 1.99
query20 0.02 0.02 0.01
query21 15.46 0.26 0.15
query22 5.22 0.06 0.06
query23 15.98 0.29 0.10
query24 0.93 0.48 0.58
query25 0.11 0.06 0.08
query26 0.15 0.14 0.13
query27 0.08 0.05 0.05
query28 4.10 1.13 0.97
query29 12.54 3.94 3.19
query30 0.28 0.13 0.12
query31 2.82 0.63 0.41
query32 3.23 0.60 0.49
query33 3.27 3.22 3.27
query34 16.39 5.35 4.70
query35 4.83 4.76 4.76
query36 0.64 0.50 0.49
query37 0.12 0.07 0.08
query38 0.08 0.04 0.04
query39 0.05 0.03 0.03
query40 0.20 0.16 0.15
query41 0.09 0.03 0.03
query42 0.05 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 97.94 s
Total hot run time: 28.46 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3870144699
<details>
<summary>TPC-H: <b>Total hot run time: 30579 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5ca3f3dbd77a6a27be7fbcb730efdc949c1a22a9, data reload: false
------ Round 1 ----------------------------------
q1 17611 4604 4352 4352
q2 2025 346 237 237
q3 10154 1289 712 712
q4 10195 781 330 330
q5 7869 2186 1992 1992
q6 205 181 145 145
q7 896 732 606 606
q8 9283 1328 1198 1198
q9 4820 4654 4649 4649
q10 6881 1945 1552 1552
q11 558 301 281 281
q12 416 369 217 217
q13 17787 4085 3242 3242
q14 231 242 214 214
q15 917 795 808 795
q16 665 677 621 621
q17 813 776 561 561
q18 6760 5791 5827 5791
q19 1473 999 625 625
q20 512 486 388 388
q21 2563 1807 1786 1786
q22 352 332 285 285
Total cold run time: 102986 ms
Total hot run time: 30579 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4447 4361 4357 4357
q2 253 353 261 261
q3 2095 2696 2207 2207
q4 1386 1735 1294 1294
q5 4290 4164 4279 4164
q6 212 183 135 135
q7 1857 1774 1665 1665
q8 2715 2601 2524 2524
q9 7530 7460 7466 7460
q10 2932 3113 2573 2573
q11 564 472 463 463
q12 683 745 608 608
q13 3873 4560 3590 3590
q14 310 334 295 295
q15 869 851 813 813
q16 679 754 729 729
q17 1194 1400 1396 1396
q18 8250 7797 8139 7797
q19 878 841 858 841
q20 2134 2137 2003 2003
q21 4797 4251 4142 4142
q22 585 538 531 531
Total cold run time: 52533 ms
Total hot run time: 49848 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-4054622790
<details>
<summary>TPC-H: <b>Total hot run time: 26647 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0802988d320b046c60feb5c64bd5d37762929d6b, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17689 4515 4304 4304
q2 q3 10643 788 511 511
q4 4682 357 254 254
q5 7584 1180 1003 1003
q6 171 175 145 145
q7 773 835 659 659
q8 9302 1424 1305 1305
q9 4953 4723 4659 4659
q10 6345 1897 1643 1643
q11 478 258 237 237
q12 766 567 468 468
q13 18022 2874 2155 2155
q14 235 229 216 216
q15 q16 759 734 673 673
q17 720 852 426 426
q18 6268 5339 5268 5268
q19 1133 964 612 612
q20 538 481 371 371
q21 4506 1817 1425 1425
q22 379 479 313 313
Total cold run time: 95946 ms
Total hot run time: 26647 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4703 4652 4590 4590
q2 q3 3854 4311 3841 3841
q4 944 1216 800 800
q5 4102 4378 4323 4323
q6 187 170 142 142
q7 1789 1652 1539 1539
q8 2514 2698 2559 2559
q9 7642 7302 7196 7196
q10 3796 4052 3651 3651
q11 501 429 420 420
q12 475 583 462 462
q13 2667 3312 2748 2748
q14 295 308 282 282
q15 q16 731 768 721 721
q17 1184 1339 1345 1339
q18 7239 6928 6562 6562
q19 882 899 901 899
q20 2027 2160 2016 2016
q21 3934 3453 3397 3397
q22 469 431 381 381
Total cold run time: 49935 ms
Total hot run time: 47868 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3822237538
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3824606149
# FE Regression Coverage Report
Increment line coverage ` 8.33% (1/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60372_6ea7c8c998ec1172e13c20767d1f480cb66c8e83_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60372_6ea7c8c998ec1172e13c20767d1f480cb66c8e83_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 closed pull request #60372: [enhance] (auth) add option to disable login with empty pass
URL: https://github.com/apache/doris/pull/60372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3823245176
run nonCurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3870798605
<details>
<summary>TPC-H: <b>Total hot run time: 30558 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5ca3f3dbd77a6a27be7fbcb730efdc949c1a22a9, data reload: false
------ Round 1 ----------------------------------
q1 17594 4576 4343 4343
q2 2038 343 227 227
q3 10171 1321 730 730
q4 10197 763 312 312
q5 7510 2178 1936 1936
q6 191 175 145 145
q7 895 732 625 625
q8 9272 1376 1082 1082
q9 4660 4618 4599 4599
q10 6811 1936 1553 1553
q11 525 300 286 286
q12 336 379 221 221
q13 17766 4040 3221 3221
q14 226 252 211 211
q15 879 811 800 800
q16 673 679 617 617
q17 690 798 518 518
q18 6455 5799 6017 5799
q19 1470 1058 678 678
q20 555 505 412 412
q21 2772 1949 2019 1949
q22 370 327 294 294
Total cold run time: 102056 ms
Total hot run time: 30558 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4572 4602 4711 4602
q2 266 372 259 259
q3 2337 2930 2396 2396
q4 1416 1822 1487 1487
q5 4615 4870 4590 4590
q6 238 182 138 138
q7 1972 1908 1805 1805
q8 2578 2496 2595 2496
q9 7595 7555 7495 7495
q10 2985 3001 2610 2610
q11 520 467 470 467
q12 699 779 624 624
q13 3843 4005 3240 3240
q14 264 286 259 259
q15 837 796 767 767
q16 650 674 643 643
q17 1101 1290 1329 1290
q18 7539 7513 7313 7313
q19 852 782 800 782
q20 1946 2042 1916 1916
q21 4442 4263 4104 4104
q22 569 537 487 487
Total cold run time: 51836 ms
Total hot run time: 49770 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3860014098
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3824058306
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3818467919
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3817950068
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3823708490
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3823605753
run nonCurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3822692664
<details>
<summary>ClickBench: <b>Total hot run time: 28.63 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6ea7c8c998ec1172e13c20767d1f480cb66c8e83, data reload: false
query1 0.06 0.05 0.05
query2 0.10 0.05 0.04
query3 0.26 0.09 0.08
query4 1.60 0.11 0.11
query5 0.26 0.24 0.25
query6 1.16 0.67 0.66
query7 0.03 0.03 0.03
query8 0.05 0.04 0.04
query9 0.56 0.48 0.49
query10 0.55 0.55 0.55
query11 0.14 0.09 0.10
query12 0.14 0.10 0.10
query13 0.63 0.61 0.61
query14 1.07 1.06 1.07
query15 0.89 0.86 0.87
query16 0.37 0.38 0.43
query17 1.12 1.15 1.14
query18 0.23 0.21 0.22
query19 2.10 2.04 2.06
query20 0.03 0.02 0.01
query21 15.42 0.28 0.15
query22 5.12 0.05 0.05
query23 15.89 0.27 0.10
query24 1.02 0.67 0.53
query25 0.09 0.10 0.05
query26 0.13 0.14 0.13
query27 0.07 0.06 0.05
query28 4.66 1.13 0.96
query29 12.61 3.95 3.16
query30 0.28 0.14 0.11
query31 2.81 0.64 0.39
query32 3.26 0.59 0.50
query33 3.27 3.24 3.32
query34 16.06 5.40 4.76
query35 4.78 4.84 4.81
query36 0.64 0.50 0.48
query37 0.12 0.07 0.07
query38 0.07 0.04 0.04
query39 0.05 0.03 0.03
query40 0.19 0.16 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.05 0.04 0.04
Total cold run time: 98.07 s
Total hot run time: 28.63 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3822811140
# FE UT Coverage Report
Increment line coverage ` 50.00% (6/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60372_6ea7c8c998ec1172e13c20767d1f480cb66c8e83/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60372_6ea7c8c998ec1172e13c20767d1f480cb66c8e83/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3822517273
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3824285742
# FE Regression Coverage Report
Increment line coverage ` 8.33% (1/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60372_6ea7c8c998ec1172e13c20767d1f480cb66c8e83_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60372_6ea7c8c998ec1172e13c20767d1f480cb66c8e83_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3869720867
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-3871284494
# FE Regression Coverage Report
Increment line coverage ` 8.33% (1/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60372_5ca3f3dbd77a6a27be7fbcb730efdc949c1a22a9_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60372_5ca3f3dbd77a6a27be7fbcb730efdc949c1a22a9_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "iaorekhov-1980 (via GitHub)" <gi...@apache.org>.
iaorekhov-1980 commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-4054473524
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhance] (auth) add option to disable login with empty pass [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60372:
URL: https://github.com/apache/doris/pull/60372#issuecomment-4054682557
<details>
<summary>TPC-DS: <b>Total hot run time: 170078 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0802988d320b046c60feb5c64bd5d37762929d6b, data reload: false
query5 4315 649 527 527
query6 331 228 207 207
query7 4206 482 270 270
query8 350 281 245 245
query9 8724 2751 2732 2732
query10 535 431 322 322
query11 6955 5206 4925 4925
query12 187 126 123 123
query13 1255 441 339 339
query14 5546 4065 3740 3740
query14_1 3100 3092 3090 3090
query15 216 201 183 183
query16 981 467 467 467
query17 959 746 644 644
query18 2442 455 353 353
query19 231 227 186 186
query20 134 128 135 128
query21 215 138 126 126
query22 13590 14460 14650 14460
query23 16358 16171 15780 15780
query23_1 15795 15861 15520 15520
query24 7186 1676 1262 1262
query24_1 1260 1251 1280 1251
query25 582 501 446 446
query26 1236 270 159 159
query27 2799 548 300 300
query28 4921 1910 1927 1910
query29 803 577 493 493
query30 306 244 198 198
query31 1028 985 880 880
query32 81 74 72 72
query33 516 342 279 279
query34 912 918 533 533
query35 669 692 593 593
query36 1116 1113 980 980
query37 133 96 83 83
query38 2944 2918 2920 2918
query39 888 830 814 814
query39_1 805 803 810 803
query40 234 156 137 137
query41 63 58 59 58
query42 266 261 259 259
query43 264 261 221 221
query44
query45 196 195 184 184
query46 942 1017 613 613
query47 2041 2116 1984 1984
query48 324 322 269 269
query49 623 495 390 390
query50 700 287 212 212
query51 4118 4110 4048 4048
query52 272 274 268 268
query53 327 362 306 306
query54 306 268 263 263
query55 93 92 85 85
query56 319 326 295 295
query57 1967 1768 1642 1642
query58 300 279 278 278
query59 2833 2981 2733 2733
query60 347 335 320 320
query61 151 146 139 139
query62 624 575 535 535
query63 325 288 284 284
query64 4935 1266 997 997
query65
query66 1450 481 345 345
query67 24381 24449 24394 24394
query68
query69 404 313 280 280
query70 949 984 977 977
query71 346 318 302 302
query72 2747 2581 2365 2365
query73 539 549 321 321
query74 9712 9608 9383 9383
query75 3067 2884 2570 2570
query76 2297 1123 720 720
query77 365 406 306 306
query78 10991 11115 10478 10478
query79 2886 798 587 587
query80 1769 651 555 555
query81 553 282 230 230
query82 998 155 123 123
query83 341 283 248 248
query84 292 122 102 102
query85 886 481 425 425
query86 425 311 300 300
query87 3216 3108 3024 3024
query88 3593 2671 2649 2649
query89 459 393 370 370
query90 2000 178 179 178
query91 167 162 137 137
query92 77 75 77 75
query93 1217 863 500 500
query94 645 306 258 258
query95 611 339 317 317
query96 645 527 225 225
query97 2480 2508 2411 2411
query98 251 225 220 220
query99 993 985 901 901
Total cold run time: 253048 ms
Total hot run time: 170078 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org