You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/09 02:38:18 UTC

[GitHub] [shardingsphere] codecov-commenter commented on pull request #22754: Fix wrong decide result when execute same sharding condition subquery with sql federation

codecov-commenter commented on PR #22754:
URL: https://github.com/apache/shardingsphere/pull/22754#issuecomment-1343766427

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22754](https://codecov.io/gh/apache/shardingsphere/pull/22754?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8905928) into [master](https://codecov.io/gh/apache/shardingsphere/commit/fb25925f76c1157c1250b24850f18633867718b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb25925) will **decrease** coverage by `0.08%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #22754      +/-   ##
   ============================================
   - Coverage     49.39%   49.31%   -0.09%     
   - Complexity     2443     2446       +3     
   ============================================
     Files          4107     4122      +15     
     Lines         57476    57679     +203     
     Branches       9847     9879      +32     
   ============================================
   + Hits          28393    28447      +54     
   - Misses        26643    26783     +140     
   - Partials       2440     2449       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sharding/decider/ShardingSQLFederationDecider.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZGVjaWRlci9TaGFyZGluZ1NRTEZlZGVyYXRpb25EZWNpZGVyLmphdmE=) | `82.75% <100.00%> (+5.83%)` | :arrow_up: |
   | [...iver/jdbc/core/driver/ShardingSphereDriverURL.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amRiYy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvamRiYy9jb3JlL2RyaXZlci9TaGFyZGluZ1NwaGVyZURyaXZlclVSTC5qYXZh) | `72.41% <0.00%> (-17.06%)` | :arrow_down: |
   | [...a/manager/XATransactionManagerProviderFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL3R5cGUveGEvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24veGEvbWFuYWdlci9YQVRyYW5zYWN0aW9uTWFuYWdlclByb3ZpZGVyRmFjdG9yeS5qYXZh) | `83.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [...r/update/AlterTransactionRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24vZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9BbHRlclRyYW5zYWN0aW9uUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `80.64% <0.00%> (-9.36%)` | :arrow_down: |
   | [...rts/statement/ral/impl/HintRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9pdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3QvaXQvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9yYWwvaW1wbC9IaW50UkFMU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
   | [...rdingsphere/infra/util/reflect/ReflectiveUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9yZWZsZWN0L1JlZmxlY3RpdmVVdGlsLmphdmE=) | `66.66% <0.00%> (-4.77%)` | :arrow_down: |
   | [...proxy/frontend/netty/CDCChannelInboundHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvbmV0dHkvQ0RDQ2hhbm5lbEluYm91bmRIYW5kbGVyLmphdmE=) | `41.17% <0.00%> (-3.09%)` | :arrow_down: |
   | [...saction/xa/XAShardingSphereTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL3R5cGUveGEvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24veGEvWEFTaGFyZGluZ1NwaGVyZVRyYW5zYWN0aW9uTWFuYWdlci5qYXZh) | `68.08% <0.00%> (-1.49%)` | :arrow_down: |
   | [...peline/mysql/ingest/client/PasswordEncryption.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlhbGVjdC9teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9teXNxbC9pbmdlc3QvY2xpZW50L1Bhc3N3b3JkRW5jcnlwdGlvbi5qYXZh) | `93.54% <0.00%> (-0.40%)` | :arrow_down: |
   | [...ngsphere/agent/core/spi/AgentTypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvQWdlbnRUeXBlZFNQSVJlZ2lzdHJ5LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [27 more](https://codecov.io/gh/apache/shardingsphere/pull/22754/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org