You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Michael Stack (Jira)" <ji...@apache.org> on 2020/03/14 22:01:00 UTC
[jira] [Comment Edited] (HBASE-23967) Improve the accuracy of the
method sizeToString
[ https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059496#comment-17059496 ]
Michael Stack edited comment on HBASE-23967 at 3/14/20, 10:00 PM:
------------------------------------------------------------------
Of note, this broke client.TestAdminShell and client.TestQuotasShell. The change was in hbase-server but these tests are over in hbase-shell so didn't run. Let me add a fix in sub-issue.
We were matching on '1G' for quote but this change made 1G into 1.00G. FYI.
was (Author: stack):
Of note, this broke client.TestAdminShell and client.TestQuotasShell. The change was in hbase-server but these tests are over in hbase-shell so didn't run. Let me add a fix in sub-issue.
> Improve the accuracy of the method sizeToString
> -----------------------------------------------
>
> Key: HBASE-23967
> URL: https://issues.apache.org/jira/browse/HBASE-23967
> Project: HBase
> Issue Type: Improvement
> Affects Versions: master
> Reporter: xuqinya
> Assignee: xuqinya
> Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.1.10, 2.2.5
>
>
> In QuotaSettings，the method of sizeToString reserved integer. But, this is not very accurate.
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G', POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNER QUOTAS
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT => 1T, VIOLATION_POLICY => NO_INSERTS
> 1 row(s) in 0.0340 seconds
> {code}
> after patch：
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G', POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNER QUOTAS
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT => 1.95T, VIOLATION_POLICY => NO_INSERTS
> 1 row(s) in 0.0230 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)