You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2017/03/23 18:27:00 UTC
Review Request 57886: Warn users about pending requests while trying
to enable Interactive Query immediately after disabling it
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57886/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-20429
https://issues.apache.org/jira/browse/AMBARI-20429
Repository: ambari
Description
-------
There is no warning shown to the user to avoid enabling of Interactive Query immediately after disabling it. Allowing the users to enable Interactive Query immediately after disabling it will result in an inconsistent state of the system. Showing a popup to warn the user about a pending batch request and stopping the enable command is required.
Diffs
-----
ambari-web/app/controllers/wizard/step7/assign_master_controller.js 326f571
ambari-web/app/messages.js bc40a26
ambari-web/app/utils/ajax/ajax.js b856e44
ambari-web/app/views/common/configs/widgets/config_widget_view.js cb5d5b9
Diff: https://reviews.apache.org/r/57886/diff/1/
Testing
-------
Verified Manually.
Ambari-web unit tests pass.
30369 passing (21s)
157 pending
Thanks,
Vivek Ratnavel Subramanian
Re: Review Request 57886: Warn users about pending requests while
trying to enable Interactive Query immediately after disabling it
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57886/#review169917
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On March 23, 2017, 6:26 p.m., Vivek Ratnavel Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57886/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 6:26 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-20429
> https://issues.apache.org/jira/browse/AMBARI-20429
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There is no warning shown to the user to avoid enabling of Interactive Query immediately after disabling it. Allowing the users to enable Interactive Query immediately after disabling it will result in an inconsistent state of the system. Showing a popup to warn the user about a pending batch request and stopping the enable command is required.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step7/assign_master_controller.js 326f571
> ambari-web/app/messages.js bc40a26
> ambari-web/app/utils/ajax/ajax.js b856e44
> ambari-web/app/views/common/configs/widgets/config_widget_view.js cb5d5b9
>
>
> Diff: https://reviews.apache.org/r/57886/diff/1/
>
>
> Testing
> -------
>
> Verified Manually.
> Ambari-web unit tests pass.
> 30369 passing (21s)
> 157 pending
>
>
> Thanks,
>
> Vivek Ratnavel Subramanian
>
>