You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/08/22 18:22:20 UTC
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14122
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
6 files changed, 317 insertions(+), 67 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/1
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#5).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
6 files changed, 323 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/5
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#9).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/env_util.cc
7 files changed, 335 insertions(+), 73 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/9
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@134
PS2, Line 134: using std::pair;
> warning: using decl 'iota' is unused [misc-unused-using-decls]
Done
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1121
PS2, Line 1121: // dir already, and we should update the existing data dir group.
> Don't we also need to flush the tablet's superblock with an updated DataDir
Yes, this will happen when we flush the tablet metadata next (e.g. when a new block is written; if no new block is written, the updated group shouldn't matter). When we serialize the superblock, we fetch the data dir group from the ddmanager rather than relying on some in-memory cached value.
There's a test for this in tablet_server-test.cc
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1124
PS2, Line 1124: CHECK(!EmplaceOrUpdate(&group_by_tablet_map_, tablet_id, DataDirGroup(group_uuid_indices)));
> Aren't we guaranteed to do an update rather than an emplace? Could we enfor
Done
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1126
PS2, Line 1126: LOG(INFO) << Substitute("Added $0 to $1's directory group: $2",
> Should also LOG why? Would be useful if we could include numbers.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 00:44:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#6).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/env_util.cc
7 files changed, 332 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/6
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 5:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs-test.cc
File src/kudu/fs/data_dirs-test.cc:
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs-test.cc@268
PS5, Line 268: dd
This could be &dds[i] to avoid the local 'dd'.
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.h
File src/kudu/fs/data_dirs.h:
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.h@339
PS5, Line 339: // 'opts'. If none exists, adds a new dir to the group and returns the dir.
Want to add what happens if all remaining dirs are full (or if none exist)? Or is that too much detail?
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1121
PS2, Line 1121: int new_uuid_idx = group_uuid_indices.back();
> Yes, this will happen when we flush the tablet metadata next (e.g. when a n
Could you add a comment here explaining that somewhat? It's not weird to expect explicit superblock manipulation here to add the new group.
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@300
PS5, Line 300: bool inject_full = ShouldInjectSpaceError(dir_);
: if (inject_full) {
: available_bytes_new = 0;
: s = Status::IOError(Env::kInjectedFailureStatusMsg, "", ENOSPC);
: }
Could we push this down into VerifySufficientDiskSpace? That'd perhaps make it easier to reuse ShouldInject from env_posix.cc.
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@1099
PS5, Line 1099: vector<int> group_uuid_indices = group.uuid_indices();
Maybe defer this copy until L1106, where it's actually needed?
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@1101
PS5, Line 1101: as
has?
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@1102
PS5, Line 1102: if (new_target_group_size == group_uuid_indices.size()) {
Is it possible for new_target_group_size to be _less than_ group_uuid_indices.size()? Like, if two threads concurrently added new directories?
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@1129
PS5, Line 1129: // If it's some other error, return it.
: return s;
Consider putting this ahead of the add-new-directory case so as to avoid the extra nesting.
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 04:15:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 10: Verified+1
Unrelated flume test failure.
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 22:31:38 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#10).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/env_util.cc
7 files changed, 336 insertions(+), 74 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/10
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1121
PS2, Line 1121: // resize groups. See KUDU-2040 for more details.
> Could you add a comment here explaining that somewhat? It's not weird to ex
Done
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 07:02:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14122/9/src/kudu/util/env_util.cc
File src/kudu/util/env_util.cc:
http://gerrit.cloudera.org:8080/#/c/14122/9/src/kudu/util/env_util.cc@44
PS9, Line 44: #include "kudu/util/path_util.h"
> warning: #includes are not sorted properly [llvm-include-order]
Done
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 21:58:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#3).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
6 files changed, 323 insertions(+), 67 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/3
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#4).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
6 files changed, 323 insertions(+), 68 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/4
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 2:
(3 comments)
Didn't review it fully, just left a few questions.
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1121
PS2, Line 1121: // Associate the tablet with the new data dir.
Don't we also need to flush the tablet's superblock with an updated DataDirGroupPB?
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1124
PS2, Line 1124: EmplaceOrUpdate(&group_by_tablet_map_, tablet_id, DataDirGroup(group_uuid_indices));
Aren't we guaranteed to do an update rather than an emplace? Could we enforce that?
http://gerrit.cloudera.org:8080/#/c/14122/2/src/kudu/fs/data_dirs.cc@1126
PS2, Line 1126: LOG(INFO) << Substitute("Added $0 to $1's directory group", (*dir)->dir(), tablet_id);
Should also LOG why? Would be useful if we could include numbers.
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 22:57:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#8).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/env_util.cc
7 files changed, 334 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/8
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 9: Code-Review+2
Still an out-of-order include in env_util.cc.
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 21:31:02 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Reviewed-on: http://gerrit.cloudera.org:8080/14122
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/env_util.cc
7 files changed, 336 insertions(+), 74 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 11
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 9:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc@1091
PS8, Line 1091: DataDirManager
> Nit: DataDirManager
Done
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc@1092
PS8, Line 1092: those in the
: // TabletSuperB
> Do you mean "those in the TabletSuperBlockPB"?
Done
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/util/env_util.cc
File src/kudu/util/env_util.cc:
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/util/env_util.cc@23
PS8, Line 23: #include <cerrno>
> warning: #includes are not sorted properly [llvm-include-order]
Done
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/util/env_util.cc@42
PS8, Line 42: #include "kudu/util/fault_injection.h"
> warning: #includes are not sorted properly [llvm-include-order]
Done
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 20:18:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 7:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs-test.cc
File src/kudu/fs/data_dirs-test.cc:
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs-test.cc@268
PS5, Line 268:
> This could be &dds[i] to avoid the local 'dd'.
Done
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.h
File src/kudu/fs/data_dirs.h:
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.h@339
PS5, Line 339: // 'opts'. If none exists, adds a new dir to the group and returns the dir,
> Want to add what happens if all remaining dirs are full (or if none exist)?
Done
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@300
PS5, Line 300: // DataDirGroup
: ////////////////////////////////////////////////////////////
:
: DataDirGroup::DataDirGroup() {}
:
> Could we push this down into VerifySufficientDiskSpace? That'd perhaps make
I don't see a very nice way to reuse ShouldInject without putting ShouldInject into env.h or moving VerifySufficientDiskSpace into env_posix. Both don't seem great. For now, I'll just move these definitions into env_util.cc with VerifySufficientDiskSpace.
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@1099
PS5, Line 1099:
> Maybe defer this copy until L1106, where it's actually needed?
Done
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@1101
PS5, Line 1101:
> has?
Done
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@1102
PS5, Line 1102: DCHECK(dir_group_lock_.is_locked());
> Is it possible for new_target_group_size to be _less than_ group_uuid_indic
No, because we only ever target one additional directory, and because we no-op if we see that we're at the target size. It's not hard to protect against that anyway, so I'll add it here.
http://gerrit.cloudera.org:8080/#/c/14122/5/src/kudu/fs/data_dirs.cc@1129
PS5, Line 1129: int tablets_in_second = FindOrDie(tablets_by_uuid_idx_map_, candidate_indices[1]).size();
: int s
> Consider putting this ahead of the add-new-directory case so as to avoid th
Done
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 06:54:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#7).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/env_util.cc
7 files changed, 331 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/7
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 8:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc@1091
PS8, Line 1091: DataDirmanager
Nit: DataDirManager
http://gerrit.cloudera.org:8080/#/c/14122/8/src/kudu/fs/data_dirs.cc@1092
PS8, Line 1092: that in the
: // SuperBlockPB
Do you mean "those in the TabletSuperBlockPB"?
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 18:16:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14122 )
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 22:12:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2907: add a dir to dir groups when full
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, ZhangYao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14122
to look at the new patch set (#2).
Change subject: KUDU-2907: add a dir to dir groups when full
......................................................................
KUDU-2907: add a dir to dir groups when full
This patch extends the directory-picking behavior when selecting
directories for new blocks if all directories in the given tablet's
group are full. It now allows the expansion of a tablet's data dir group
if healthy directories are available.
This doesn't change the policy for picking directories for groups; it
only extends the usage of the policy to potentially add directories when
getting a directory for a new block.
Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
---
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tserver/tablet_server-test.cc
6 files changed, 318 insertions(+), 67 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/14122/2
--
To view, visit http://gerrit.cloudera.org:8080/14122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e05bdfe1fc2ac0e7152d493f289d3ac6e850d7
Gerrit-Change-Number: 14122
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>