You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/02 17:51:56 UTC
[GitHub] [beam] Mark-Zeng opened a new pull request #11895: [Beam 9879] Null String Not Encoded
Mark-Zeng opened a new pull request #11895:
URL: https://github.com/apache/beam/pull/11895
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #11895: [Beam 9879] Null String Not Encoded
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #11895:
URL: https://github.com/apache/beam/pull/11895#discussion_r434095216
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlOperators.java
##########
@@ -72,6 +82,23 @@ public static SqlFunction createSimpleSqlFunction(String name, SqlTypeName retur
SqlFunctionCategory.USER_DEFINED_FUNCTION);
}
+ public static SqlUserDefinedAggFunction createUdafOperator(
+ String name,
+ SqlReturnTypeInference returnTypeInference,
+ AggregateFunction function) {
+ return new SqlUserDefinedAggFunction(
Review comment:
Nice. By doing so it becomes a extensible way to define other AGG functions that Calcite does not have.
Glad you figured it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #11895: [Beam 9879] Null String Not Encoded
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-637732918
Consider using the Gradle check commands:
```
./gradlew :sdks:java:extensions:sql:zetasql:check
./gradlew :sdks:java:extensions:sql:check
```
The `:check` will not only run unit tests, but also does style check.
Also you can use `./gradlew spotlessApply` to fix some style issues (unfortunately not all).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia edited a comment on pull request #11895: [Beam 9879] Null String Not Encoded
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-637726461
Also update your PR title to say `support STRING_AGG function in Beam ZetaSQL`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #11895: [Beam 9879] Null String Not Encoded
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-637726461
Also update your PR title to say what support STRING_AGG function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia merged pull request #11895: [Beam 9879] support STRING_AGG function in Beam ZetaSQL
Posted by GitBox <gi...@apache.org>.
amaliujia merged pull request #11895:
URL: https://github.com/apache/beam/pull/11895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #11895: [Beam 9879] Null String Not Encoded
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #11895:
URL: https://github.com/apache/beam/pull/11895#discussion_r434092819
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLPlannerImpl.java
##########
@@ -158,6 +158,9 @@ public RelRoot rel(String sql, QueryParameters params) {
RelNode convertedNode =
QueryStatementConverter.convertRootQuery(context, (ResolvedQueryStmt) statement);
+
+ LOG.info("Calcite Plan>\n" + convertedNode.toString());
Review comment:
Remove this line in the final PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #11895: [Beam 9879] support STRING_AGG function in Beam ZetaSQL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-638424051
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #11895: [Beam 9879] support STRING_AGG function in Beam ZetaSQL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-638514897
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #11895: [Beam 9879] Null String Not Encoded
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #11895:
URL: https://github.com/apache/beam/pull/11895#discussion_r434081404
##########
File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -3130,6 +3130,23 @@ public void testUnnestArrayColumn() {
pipeline.run().waitUntilFinish(Duration.standardMinutes(PIPELINE_EXECUTION_WAITTIME_MINUTES));
}
+ @Test
+ public void testStringAggregation() {
+ String sql =
+ "SELECT STRING_AGG(fruit) AS string_agg"
+ + " FROM UNNEST([\"apple\", \"pear\", NULL, \"banana\", \"pear\"]) AS fruit";
Review comment:
In fact, I think it was a decision to not handle NULL in string coder.
So the easiest way to move forward is to not include `NULL` in your test case, and leave a comment to say that `STRING_AGG` does not handle `NULL` value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #11895: [Beam 9879] Null String Not Encoded
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #11895:
URL: https://github.com/apache/beam/pull/11895#discussion_r434093070
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlStdOperatorMappingTable.java
##########
@@ -211,7 +213,7 @@
// aggregate UDF
// .put("array_agg", )
// .put("array_concat_agg")
- // .put("string_agg")
+ .put("string_agg", SqlOperators.STRING_AGG_STRING_FN)
Review comment:
Ah yes. This should also work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Mark-Zeng commented on pull request #11895: [Beam 9879] support STRING_AGG function in Beam ZetaSQL
Posted by GitBox <gi...@apache.org>.
Mark-Zeng commented on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-638156943
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #11895: [Beam 9879] Null String Not Encoded
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-637716146
cc @jhnmora000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org