You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/28 20:18:52 UTC

[GitHub] [druid] knoguchi commented on a change in pull request #7590: Add single-machine deployment example cfgs and scripts

knoguchi commented on a change in pull request #7590:
URL: https://github.com/apache/druid/pull/7590#discussion_r416895607



##########
File path: examples/bin/run-druid
##########
@@ -34,7 +34,7 @@ else
   CONFDIR="$2"
 fi
 
-CONFDIR="$(cd "$CONFDIR" && pwd)/druid"
+CONFDIR="$(cd "$CONFDIR" && pwd)"

Review comment:
       Why was the /druid removed?  It's a breaking change for older version users.  It doesn't seem like an absolutely necessary change.  This file is one of the bin scripts in the apache-druid.tar.gz distribution although the directory name is "examples". Please avoid similar changes in the future release.  Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org